search

nextcloud / unsplash

📸🔀☁️ Random Nextcloud log in background from Unsplash
https://apps.nextcloud.com/apps/unsplash
GNU Affero General Public License v3.0
92 stars 23 forks source link

Splash - not supported on Nextcloud 28 #131

Closed Danielson89 closed 1 month ago

Danielson89 commented 9 months ago

use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug: I believe the 2.2.1 isn't supported on NextCloud 28

To Reproduce: Steps to reproduce the behavior: It's not displaying the images at the login as it normally would

Expected behavior: Not showing on the login screen, attempted to remove app and reinstall app, rebooted services, server etc

Screenshots: Screenshot will show the app successfully installed and no background photo

Server:

Additional Information: It's such a cool app, hope to get it working again Thanks Daniel - Perth Western Australia.

Raemsna commented 9 months ago

maybe related to #123 ?

TakeshiTurk commented 8 months ago

Not related @Raemsna. Issue is settings page does not work.

resim

newhinton commented 8 months ago

I am currently working on an update for Splash. I already fixed the bug you found, but there is still a bit more to do. I hope to be done before christmas!

ste7enm commented 8 months ago

Not related @Raemsna. Issue is settings page does not work.

Perhaps related to this and the fix, I'm in NextCloud 28.0.1 and have enabled Splash. It works, but no modifications made in the settings (under Theming) save. It claims that it's saved, but then you refresh and everything has reset to default settings. Other changes made under Theming to non-Splash settings are saved correctly.

Changes Changes made and saved. Refresh Settings after refreshing page.

Edit: Just to add a bit more colour in case it's related and useful: Log

BenH4 commented 7 months ago

Not related @Raemsna. Issue is settings page does not work.

Perhaps related to this and the fix, I'm in NextCloud 28.0.1 and have enabled Splash. It works, but no modifications made in the settings (under Theming) save. It claims that it's saved, but then you refresh and everything has reset to default settings. Other changes made under Theming to non-Splash settings are saved correctly.

Changes Changes made and saved. Refresh Settings after refreshing page.

Edit: Just to add a bit more colour in case it's related and useful: Log

I am having the same issue on a fresh install of NC

ChildLearningClub commented 7 months ago

This is by no means a fix, but will make it so that "Set random image as dashboard background" is on by default and should get the dashboard background working on 28.01. 

cd nextcloud/custom_apps/unsplash/lib/Services
sudo nano SettingsService.php

change line: return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 0) == 1; to: return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 1) == 1;

BenH4 commented 7 months ago

This is by no means a fix, but will make it so that "Set random image as dashboard background" is on by default and should get the dashboard background working on 28.01.

cd nextcloud/custom_apps/unsplash/lib/Services
sudo nano SettingsService.php

change line: return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 0) == 1; to: return $this->config->getAppValue($this->appName, self::STYLE_DASHBORAD, 1) == 1;

Did the trick, not a fix indeed but thanks!!!

jet438 commented 7 months ago

Any update on this? I'm still waiting to update to NC28 but don't want to do so without Splash. too cool of an app.

newhinton commented 7 months ago

I am infact working on support for 28. I have fixed most issues with the latest version, but i still have to test some new features. I couldnt spare much time for this project, so progress has been slow.

SK-Crow commented 7 months ago

Noting that @ste7enm is correct with one of the issues on Hub 28, I'm getting the same error message in my logs. Just commenting ot keep an eye on it.

ste7enm commented 7 months ago

Any update on this? I'm still waiting to update to NC28 but don't want to do so without Splash. too cool of an app.

I'll mention too that it does work in NC28 (in that you do get random images from Unsplash displayed as background images, as intended), it's just that you can't make changes to your settings (at least for me). So if you're cool with keywords "nature,nature" and not making any other tweaks, you could still update @jet438.

SK-Crow commented 7 months ago

Any update on this? I'm still waiting to update to NC28 but don't want to do so without Splash. too cool of an app.

I'll mention too that it does work in NC28 (in that you do get random images from Unsplash displayed as background images, as intended), it's just that you can't make changes to your settings (at least for me). So if you're cool with keywords "nature,nature" and not making any other tweaks, you could still update @jet438.

I found that it doesn't function at all. It doesn't break anything on my end, but both saving and splash login are not functioning. It's like it's not there at all. Just errors.

image image image

ste7enm commented 6 months ago

I found that it doesn't function at all. It doesn't break anything on my end, but both saving and splash login are not functioning. It's like it's not there at all. Just errors.

You're right, if you're logged out, you get the default clouds. As soon as I log in though, I get nature images. 🤷‍♂️

ingsocdev commented 6 months ago

Hopefully this is still in progress 🤞 I really want to use this with NC 28. Nothing works right now for me with this.

newhinton commented 6 months ago

Hopefully this is still in progress 🤞 I really want to use this with NC 28. Nothing works right now for me with this.

Yes! I finally figured out why the images weren't loading anymore on the login-screens. Now i only have to add a small attribution-icon to the login-pages, and i should be good to go!

newhinton commented 6 months ago

If you are willing, #133 contains an updated version of splash. It should work with 28, and it also provides a few bug fixes AND features, like image-caching and source attribution on the loginscreen!

image

It is currently in testing, so there might be bugs.

ingsocdev commented 6 months ago

Let me see if I can give this version a try!

crocobc commented 6 months ago

If you are willing, #133 contains an updated version of splash. It should work with 28, and it also provides a few bug fixes AND features, like image-caching and source attribution on the loginscreen! It is currently in testing, so there might be bugs.

Hi there,

Working nice with this pull. (Nextlcoud 28.0.3)

Thank you

theron29 commented 5 months ago

Can this please be released into official Nextcloud store for v28? Thanks.

jger3110 commented 5 months ago

Too bad there is nothing happening here. The second app I use that needs to be removed because of the incompatibility. Waiting months and now even 5 minor NC versions for an update that somehow is only available by some pull (???) is just not worth it. Thanks for the time it lasted...

newhinton commented 5 months ago

Waiting months and now even 5 minor NC versions for an update that somehow is only available by some pull (???) is just not worth it.

The good news is that instead of complaining that someone else is doing the work not fast enough for you, you could instead help out by either adding code or doing a review.

As long as i am not getting paid and using my free time, i will do changes when i want to do them. As always: It will be done, when it will be done.

jger3110 commented 5 months ago

Please do as you please, nobody is urging you to do anything. But as with every product or service: if it is not reliably available people will stop using it. Just as it is your right to maintain it. Or not. And please forgive me for expressing my opinion just as you expressed yours by stating what you want to do and what not.

newhinton commented 5 months ago

I know that this release has taken quite a while. And i would really like to get it out, there is a lot of work and quite a few features in there. But time is limited, and it really isn't that useful to be told that it took that long.

This PR is feature complete, that means the basics are done. There are still a few things to work out before a release, as reported by the others in said PR. Once those are fixed, i will release it proper. Thank you for your understanding and patience.

jger3110 commented 5 months ago

Danke Felix, dieses Statusupdate ist hilfreich. daumenhoch

waja commented 5 months ago

While working on compatibility for 28, you can already target 29, which is going to be released soon. ;)

asheroto commented 4 months ago

Looks like Nextcloud 29 is being released tomorrow, April 24, 2024.

The end of life (security support) for Nextcloud 27 is in June 2024.

image

Any updates on these? 😊

newhinton commented 4 months ago

@asheroto You can track the progress of 28 support over here: #133

I have just updated some error handling regarding the unsplash api, if you are willing, testers are always welcome!

monjurq commented 1 month ago

Nextcloud Version: Nextcloud Hub 8 (29.0.4) Splash Version: 2.2.1 Background auto change isn't working. (it worked in the past) No changes were made in the admin area under themes!! PLEASE FIX IT, Thank You.