Closed newhinton closed 5 years ago
There are two issues open (#5 and #6) which suggeest different image sources. The pr #29 can allow different sources for images and it could be a basis for such a development.
I would be happy to change the name. One thing only:
If we want to keep the current users, which is probably a good idea, we would not be able to change is the Nextcloud app ID (as far as I know ā @MorrisJobke @rullzer correct?) This means it would always be https://apps.nextcloud.com/apps/unsplash
in the app store, the apps subfolder would stay unsplash
and on updates Nextcloud would say New name (unsplash)
. But everything else I think would be changed.
We can simply rename the app in this repository, or we can also move it out of my personal profile into an organization when we find a name. I would prefer that since itās a group effort anyway.
Then coming to names ā does anyone have any ideas? Unsplash is short and nice, but itās also a specific platform and they donāt use CC0 anymore. As said, Wikimedia Commons would be nice, but just in case we add others as well (like Pixabay which is CC0), maybe itās best to not use a specific product name.
I like the simple "Nature" name. Itās a splash of nature in the otherwise digital interface ("some Nature for Nextcloud"). And yes, I do think we should stick to nature images cause they look nice. :) (And apparently pop psychology says itās calming.)
What do you think?
If we want to keep the current users, which is probably a good idea, we would not be able to change is the Nextcloud app ID (as far as I know ā @MorrisJobke @rullzer correct?)
Correct.
@jancborchard @mwieschollek While im taking a look at wikimedia, i want to make this app more generic, so that we can provide different imageprovider from which an admin can choose. We should change the appname, while we're at it. Any further suggestions there?
Some of my silly ideas: Colourful Advanced Theming Random Images
I like Splash for Nextcloud
as a name, or Nature for Nextcloud
.
I like the first a bit better, because it maintains ambiguity in case you guys decide to implement custom search terms.
afaik 'nextcloud' is a term which is not allowed in an appname
Letās go for Splash. Itās short, similar to the previous name, versatile and not only limited to nature if that ever changes. Think "splash of color" or "splash screen". :)
@jancborchardt I have started developing a way to serve multiple different providers of images. While we are at it, what provider do we want to serve? currently i'm planing on providing unsplash and wikimedia commons, and if the postprocessing-pr is accepted a provider to serve the default backgroundimage from the normal theming
@newhinton Iād say Unsplash and Wikimedia Commons are fine and enough too? Thereās also Pixabay and Pexels but they both have the same license as Unsplash so we donāt really need to add them.
Heyhey @newhinton @marius-wieschollek ā considering I donāt really find the time to work on this app anymore (also as the first prototype already did what I wanted and itās technically beyond my abilities ;) Iām wondering if you would like to take over maintainership together?
Because otherwise Iād feel like Iād just be blocking progress on the app by being idle, and thatās not nice considering all the good open pull requests for enhancements.
I guess we also have to ask @MorrisJobke how to exactly handle it. If it makes sense Iād like the app to be moved to the https://github.com/nextcloud organization so it also doesnāt just look like Iām the only one working on it.
Let me know what you think! :)
@jancborchardt nice to hear that you are still alive ^^ i don't think this app will require a whole lot of maintenance, so i'd be willing to help out :D
I guess we also have to ask @MorrisJobke how to exactly handle it. If it makes sense Iād like the app to be moved to the https://github.com/nextcloud organization so it also doesnāt just look like Iām the only one working on it.
Yep - just moving it over should work :)
Ok, so then I would move the app over to the Nextcloud organization. :) Just want to wait on an answer from @marius-wieschollek as well since itās always best to have 2 maintainers at least.
Some other things:
Anything else? :)
@jancborchardt I would be willing to help out with the development of the app.
@jancborchardt We would also need to transfer ownership in the nextcloud-appstore if we use new keys
will you have time in the near future that we can discuss it? maybe on irc or something like that?
Sorry for the delay!
[ ] we need to get a new appstore key. @MorrisJobke whatās the process here ā I guess @newhinton for example opens a pull request with a new certificate at https://github.com/nextcloud/app-certificate-requests/tree/master/unsplash ?
Why this? Don't you have it anymore? You could reuse that?
And if so: yes new CSR.
@MorrisJobke so I just send my part of the cert to @newhinton? I mean, doesnāt it have my ID in it?
@jancborchardt If @MorrisJobke says reusing the same cert is fine, you can contact me unsplash[enterspecialAhere]felixnuesse.de so that we can privately discuss on how to transfer the certs :D
@MorrisJobke so I just send my part of the cert to @newhinton? I mean, doesnāt it have my ID in it?
Correct. The cert is just a signed proof from our side. You generated the CSR with a generated secret on your side. This allows to sign new app releases and those release signatures can be verified by checking against our root cert, because it signed your secret, that is used to sign the app by yourself. So it is only personalized to you in a way that only you have access to it. So it's fine to give it to the new maintainer and giving the new maintainer this power to sign that app.
Keep in mind that you need to send @newhinton the secret (often called key
) and not the cert (which is the public part).
Hey guys,
since unsplash seems to have had some issues with timeouts yesterday (https://status.unsplash.com/), which resulted in blank background image on my nextcloud instance, i started reading some issues in this repo.
First of all i wanted to thank you very much for your great work on this app! I love to be suprised by a nice picture on login.
I tought you might be interested in some user feedback and that is why im posting here, even if im not really able to help you (code the app).
Here my to cents for the future of the app and its features:
I'd really like to see the image source as in @marius-wieschollek solution to issue #9
I am not using the feature that replaces the background of the navigation bar, because it often has a random picture with white color or even little contrast to the icons in that area . As a result, you cant see the icons. I wouldnt mind, if you drop this feature.
If you would change to wikimedia commons or other sources, i'd like to be able to choose the category or multible categories to get the random pictures from, if that would be possible. I think, this is the same as intended in #4
Another request which i would back, is to change the randomisation to daily (or weekly). This would maybe also make it possible to cache the picture in the cloud for the day, if the copyrights allow caching at all. E.g. bing.com changes the picture daily and i like that.
Finally thanks for your great work again and if you didnt want any user feedback here, just ignore it. ;-)
Greetings, Hell-o-Admin
@Hell-o-Admin
thank you for your feedback!
i'll write some lines to your questionv
1) I will need to see if this can added in the future. We have some licensing issues which block his pr until we take a closer look at it. However, steps have been taken to include this in the future (but don't wait for it, it may take a while)
2) You should already be able to disable this on a per user basis, but there will be the ability to further modify this in the near future
3) I have already taken steps to implement that, take a look at#44
However, the api is not easy to understand and currently only dogs (and cats) are returned as images. Help here would be greatly welcomed :)
4) This was already implemented by @marius-wieschollek in his pr regarding the image attribution, so we need to look at this at well.
I guess we can close this issue as itās transferred? :)
@hell-o-admin thanks or the feedback! Itās always best to check if issues already exist (in that case comment there) or if they donāt open separate issues for separate things.
This issue is here to allow us to discuss the future of this app. Since there are things that changed regarding licensing of images from the unsplash-service, there may be features which may not be possible.
Everyone is invited to join this discussion and help us improve this app!
Currently, one idea is to move away from unsplash as an image-provider, to wikimedia-commons as an example. Suggestions are welcome!