search

nextcloud / unsplash

📸🔀☁️ Random Nextcloud log in background from Unsplash
https://apps.nextcloud.com/apps/unsplash
GNU Affero General Public License v3.0
92 stars 23 forks source link

Picture background used for navigation bar, even if "use pic for nav bar" is deactivated -> readability issue #92

Closed chrisbley closed 2 years ago

chrisbley commented 2 years ago

image image

checkbox in Administration / Design not doing what it's supposed to do: keep the nav bar free from pic

newhinton commented 2 years ago

Which version of nextcloud and splash are you using?

chrisbley commented 2 years ago

I'm using linuxserver/nextcloud:23.0.3-php8 with Splash 1.2.4

newhinton commented 2 years ago

hm, i can't reproduce that. Have you tried flushing the cache? Or using a different browser?

chrisbley commented 2 years ago

thanks for looking into it! yes, flushing the cache doesn't help, same result on brave and edge browsers.

newhinton commented 2 years ago

Do you have the custom-css app activated? Your bar seems strange, why is it so big?

newhinton commented 2 years ago

Is that your dashboard?

chrisbley commented 2 years ago

No custom css app, but I used the margin 0px work around on dashboard.css since my post. Yes, this was my dashboard.

newhinton commented 2 years ago

In that case it is working as intended. There is a seperate switch, the third one in your screenshot, that controls the dasboard background.

chrisbley commented 2 years ago

Again, I appreciate you looking into it! But I'm not getting it: shouldn't the navigation bar even on the dashboard page look like this if I deactivate the middle checkbox from my screenshot? no picture background on the nav bar? image

newhinton commented 2 years ago

No, the navigation bar in the dashboard has a transparency applied so that the default blue cloud will be fully visible. That is intended by the nextcloud design team, and it works with most pictures, and nextcloud ships with some images that work well.

And the splash app follows this logic. We just replace the background image, but do not edit the transparency of the navigation bar.

You can use this with either the custom css app (easy, does not break updates) or edit the dashboard.css-file in the unsplash directory directly (does break updates, i think.)

#header {
  background: var(--color-primary-element) !important;
}

This block of code will reintroduce the main color in every navigation bar, including the dashboard.

I am not sure if we really need to introduce another setting, since the default dashboard image provides a clear readability. I will close this for now, but we may revisit this if more users have objections or a need for this.

chrisbley commented 2 years ago

Understood, thank you very much!