nextcloud / unsplash

πŸ“ΈπŸ”€β˜οΈ Random Nextcloud log in background from Unsplash
https://apps.nextcloud.com/apps/unsplash
GNU Affero General Public License v3.0
92 stars 23 forks source link

TOTP does not follow login style #97

Closed newhinton closed 1 year ago

newhinton commented 2 years ago

https://github.com/nextcloud/twofactor_totp/issues/1006

skjnldsv commented 2 years ago

Fixed with 25 image

newhinton commented 2 years ago

Is this fixed for all currently supported versions?

did that also fix the custom css loading, or just the background image loading?

skjnldsv commented 2 years ago

Login design is also applied, that include dark/light theme and primary colours

newhinton commented 1 year ago

@skjnldsv It is still impossible to load css on the core.TwoFactorChallenge.showChallenge-route. It tries to redirect the added header from a public page.

skjnldsv commented 1 year ago

@newhinton Adding css? Why are you adding css? The totp style is compliant to what the login is using now. That's what this issue is about

image

newhinton commented 1 year ago

But this is about unsplash. We change the login screen, and then it does not match anymore.

Unsplash should also set the background for totp or other sites like sharing. But the totp-route does not properly resolve puplic css-header as explained in the linked issue above

skjnldsv commented 1 year ago

See linked PR