Improve user experience of the Updater by changing order of operations (WIP/RFC) - Githubissues

nextcloud / updater

:arrows_counterclockwise: The updater app to keep your Nextcloud up-to-date

GNU Affero General Public License v3.0

45 stars 31 forks source link

Improve user experience of the Updater by changing order of operations (WIP/RFC) #525

Open joshtrichards opened 6 months ago

joshtrichards commented 6 months ago

Some steps are more likely to take longer than others
Some steps make others unnecessary if they fail (e.g. if the update can't be downloaded or extracted)

e.g.

checkForExpectedFilesAndFolders()
checkWritePermissions()
downloadUpdate()
verifyIntegrity()
extractDownload()
createBackup() <---- moves here from step 3
setMaintenanceMode()
replaceEntryPoints()
deleteOldFiles()
moveNewVersionInPlace()
setMaintenanceMode
finalize

The current order is as follows:

https://github.com/nextcloud/updater/blob/4d660d83db17a6cc6ce8c28f4ce38fa19932d054/index.php#L1335-L1372

Other considerations:

maintenance mode / end-users hitting the server
entrypoint replacement timing

joshtrichards commented 4 months ago

Related: #386