search

nextcloud / updater

:arrows_counterclockwise: The updater app to keep your Nextcloud up-to-date
GNU Affero General Public License v3.0
47 stars 32 forks source link

add `.php-ini` and `.php-version` to expected files #575

Open JohnRDOrazio opened 4 months ago

JohnRDOrazio commented 4 months ago

Even though the two files .php-ini and .php-version are not directly provided by nextcloud, they are however provided by my Plesk setup. It get's a bit annoying to have to move them out of the nextcloud folder in order to do the update, and then move them back in again after. I can't see any counter-indication to including them in the "expected" list?

https://github.com/nextcloud/updater/blob/3b634b922aa48f132e40e65006cae37a1705761e/index.php#L247-L297

May I create a PR that addresses this?

JohnRDOrazio commented 4 months ago

I tested adding the two mentioned files to the expected files, and the builtin update went smoothly. Perhaps the related PR could be considered?

joshtrichards commented 1 month ago

Given these are atypical filenames, maybe #372 makes more sense. Though I'm hesitant to make it so easy to ignore non-distributed files being in the installation folder, since it can lead to weird problems.