search

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
108 stars 64 forks source link

Rewrote "bad" Code to more modern version #108

Open melvin-suter opened 4 years ago

melvin-suter commented 4 years ago

As discussed in #100 here is the PR with the rewroten if/else statement.

violoncelloCH commented 4 years ago

thank you very much for your contribution! indeed, your changes make sense however this needs proper testing in different scenarios before merging, but unfortunately I neither have an SMB setup nor enough time to do this at the moment :/

violoncelloCH commented 4 years ago

@ufozone simply "accepting" the PR doesn't really help here, because I don't know what this "accepting" is based on. Instead please test it as much as possible and explain what you tested in detail :)