nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
108 stars 64 forks source link

user_external should log error message if authentication over imap does not work #11

Closed yennor closed 5 years ago

yennor commented 7 years ago

Affected apps

user_external

Expected behaviour

If user_external can not login over imap show a message what the error was!

Actual behaviour

It just shows a general purpose error message, that login was not successful.

It took me over an hour to find out, that the user_external app was properly enabled and even executed, just that the server certificate was wrong. I managed to find that out by adding only adding a single line to imap.php

OCP\Util::writeLog('user_external', implode('|', imap_errors()), OCP\Util::ERROR);

Steps to reproduce

  1. activate user_external app
  2. change config.php to activate login over imap (but have an error in your configuration)
  3. try to login
pmgouveia commented 7 years ago

thanks! ^^

violoncelloCH commented 5 years ago

@yennor could you create a PR implementing proper error handling?

violoncelloCH commented 5 years ago

should be fixed with #34 thanks @anojht !