Examine error code returned by curl handle instead of return value from curl_exec. Using the return value from curl_exec resulted in failure on new mailboxes that did not contain any mail.

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP

https://apps.nextcloud.com/apps/user_external

108 stars 64 forks source link

Closed tem-hth closed 1 year ago

tem-hth commented 3 years ago

fixes #154

violoncelloCH commented 3 years ago

thanks @tem-hth I guess this possibly fixes #154 right?

violoncelloCH commented 3 years ago

also, there are 3 commits for those few changes... could you rebase and squash them (into a single commit) and also add the sign-off? (https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work)

richarson commented 1 year ago

Hello!

I tried this patch in my NC 21.0.9 with user_external 2.1.0 and it seems to be working for me.

At first I seem to have made a mistake and got error 500 but I just tried again and so far so good.

I'll report at the end of the day if I get any more errors, but if you could merge this PR I'd be very grateful :)

richarson commented 1 year ago

So far, so good! No other issues experienced.

Can this please be merged? Who can be pinged to review and approve the change?