search

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
107 stars 64 forks source link

Updater remove favorites for external users #181

Open gnilebein opened 2 years ago

gnilebein commented 2 years ago

Steps to reproduce

  1. Add Files to your favorites
  2. Update NC using NC updater
  3. Updater Task "Clean tags and favorites" seams to clean favorites for external users

Expected behaviour

Favorites shouldn not be cleaned

Actual behaviour

Favorites get cleaned by NC Update (Task: Clean tags and favorites)

Affected Authentication backend

I think every Backend. In my special case Basic Auth

Server configuration

User External App version: 2.0.0

Operating system: Ubuntu 16.04.7 LTS

Web server: Apache 2.4.18

Database: MySQL

PHP version: 7.4

Nextcloud version: 21.0.4

Updated from an older Nextcloud/ownCloud or fresh install: Updated

Where did you install Nextcloud from: Nextcloud Website

Signing status:

Signing status ``` No errors have been found. ```

List of activated apps:

App list ``` Enabled: - accessibility: 1.7.0 - activity: 2.14.3 - apporder: 0.13.0 - calendar: 2.3.1 - circles: 0.21.4 - cloud_federation_api: 1.4.0 - comments: 1.11.0 - contacts: 4.0.1 - contactsinteraction: 1.2.0 - dashboard: 7.1.0 - dav: 1.17.1 - deck: 1.4.3 - external: 3.8.2 - federatedfilesharing: 1.11.0 - federation: 1.11.0 - files: 1.16.0 - files_automatedtagging: 1.11.0 - files_mindmap: 0.0.25 - files_pdfviewer: 2.1.0 - files_retention: 1.10.1 - files_rightclick: 1.0.0 - files_sharing: 1.13.1 - files_trashbin: 1.11.0 - files_versions: 1.14.0 - files_videoplayer: 1.10.0 - firstrunwizard: 2.10.0 - forms: 2.3.0 - groupfolders: 9.0.2 - logreader: 2.6.0 - lookup_server_connector: 1.9.0 - notes: 4.1.1 - notifications: 2.9.0 - oauth2: 1.9.0 - password_policy: 1.11.0 - photos: 1.3.0 - polls: 3.0.0 - privacy: 1.5.0 - provisioning_api: 1.11.0 - rainloop: 7.1.2 - richdocuments: 4.2.1 - serverinfo: 1.11.0 - settings: 1.3.0 - sharebymail: 1.11.0 - side_menu: 1.27.1 - support: 1.4.0 - survey_client: 1.9.0 - systemtags: 1.11.0 - tasks: 0.14.1 - text: 3.2.0 - theming: 1.12.0 - twofactor_backupcodes: 1.10.0 - updatenotification: 1.11.0 - user_external: 2.0.0 - user_status: 1.1.1 - viewer: 1.5.0 - weather_status: 1.1.0 - workflowengine: 2.3.0 Disabled: - admin_audit - announcementcenter - encryption - files_external - mail - nextcloud_announcements - recommendations - user_ldap ```

Nextcloud configuration:

Config report ``` { "system": { "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "default_phone_region": "DE", "defaultapp": "apporder", "trusted_domains": [ "nextcloud.xxx.de", "localhost" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "21.0.4.1", "overwrite.cli.url": "http:\/\/localhost", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "3306", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "instanceid": "***REMOVED SENSITIVE VALUE***", "htaccess.RewriteBase": "\/", "maintenance": false, "theme": "", "loglevel": 2, "user_backends": [ { "class": "OC_User_BasicAuth", "arguments": [ "https:\/\/intern.xxxx.de\/", "https:\/\/xxxx-intern.de\/" ] } ], "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_sendmailmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpauthtype": "PLAIN", "mail_smtpauth": 1, "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "465", "mail_smtpname": "***REMOVED SENSITIVE VALUE***", "mail_smtppassword": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "ssl", "app_install_overwrite": [ "user_external" ] } } ```

Logs

Web server error log

Web server error log ``` No relevant logging ```

Nextcloud log (data/nextcloud.log)

Nextcloud log ``` No relevant logging ```

Browser log

Browser log ``` No relevant logging ```
liquidat commented 2 years ago

I can confirm this for the IMAP backend. Happened for all recent updates, including the most recent update to v24.

snetat commented 1 year ago

I have the same problem with a self-written REST-Plugin.

I think favorites are stored in oc_vcategory and oc_vcategory_to_object. A short test with backup and restore of these tables was successful.

Does anyone have information how the nextcloud upgrade process works, which sql routines are executed and where they are located ?

jmcclelland commented 11 months ago

There is a core issue (incorrectly close) that provides more info: https://github.com/nextcloud/server/issues/7615

It seems like it is a bug not just for user_external but for any server running an alternative user backend. It seems that the problem is with clean up steps that are run during an upgrade while third party apps are disabled. One of the deletes favorites for any user that no longer exists. And, if user_external is disabled, than none of our users exist at that moment.

PeteKersker commented 7 months ago

I'm having the same problem. I'm currently running NC27. Every upgrade since NC24 deleted my favorites: In case any of these contribute to the issue, my Install includes: 1) IMAP Authentication 2) Group Folders 3) S3 Storage