nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
107 stars 64 forks source link

migration/changes for nextcloud 23/24, bump UserExternal v3.0.0 #191

Closed MarBie77 closed 2 years ago

MarBie77 commented 2 years ago

Signed-off-by: Biermair Martin martin.biermair@wimbergerhaus.at

Fixes #186

Changes proposed in this pull request:

VVD commented 2 years ago

How to migrate existing external users? Didn't find the description in the README.md. Thanks!

MarBie77 commented 2 years ago

There is no need to migrate the users. But you have to change your config to the new namespace (class names), see README.md.

VVD commented 2 years ago

There is no need to migrate the users.

Ok, thanks.

But you have to change your config to the new namespace (class names), see README.md.

Yes, already read this.

violoncelloCH commented 2 years ago

thanks for your PR @MarBie77 ! @ChristophWurst could you maybe take a quick look and tell me if this seems good to you? (I'm not really up to date on the latest Nextcloud best practices regarding app development) I'd then create a new release this week-end (possibly also for Nextcloud 24)

skjnldsv commented 2 years ago

@MarBie77 didn't see that PR, coul dyou trake the workflows/composer from https://github.com/nextcloud/user_external/pull/192 and add them here please? You can also remove drone

violoncelloCH commented 2 years ago

I just tried to activate user_external from this branch, but get

{"reqId":"8n52aJhC41keGQWqkj5z","level":3,"time":"2022-04-14T13:40:03+00:00","remoteAddr":"192.168.21.3","user":"admin","app":"PHP","method":"POST","url":"/index.php/settings/apps/enable","message":"Cannot declare class OCA\\UserExternal\\AppInfo\\Application, because the name is already in use at /var/www/html/apps/user_external/lib/AppInfo/Application.php#14","userAgent":"Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Firefox/99.0","version":"24.0.0.8"}

when clicking on activate in the Apps... not sure if this is just an issue with my dev setup though :thinking: ?

violoncelloCH commented 2 years ago

okay I think I found it and pushed a fix for it... I've also increased the version number to 3.0.0