PHP 8.1 support: trim(): Passing null to parameter #1 ($string) of type string is deprecated at lib/Base.php#69

[VVD]

Log:

trim(): Passing null to parameter #1 ($string) of type string is deprecated at /nextcloud/apps/user_external/lib/Base.php#69

Patch:

--- lib/Base.php
+++ lib/Base.php
@@ -66,7 +66,7 @@
                $user = $result->fetch();
                $result->closeCursor();

-               $displayName = trim($user['displayname'], ' ');
+               $displayName = trim($user['displayname'] ?? '', ' ');
                if (!empty($displayName)) {
                        return $displayName;
                } else {

[VVD]

ping

[violoncelloCH]

hey, would you mind submitting your patch as a Pull Request ? :)

[Popyllol]

This patch works fine for me as well!

Version of Nextcloud: 25.0.2.3

[VVD]

hey, would you mind submitting your patch as a Pull Request ? :)

Hello! I can't do - this operation require fork of all repository for 1 line (4 letters) patch. :-o Just get it from text, plz. [-8

[Glandos]

PR submitted. Via GitHub web interface only ;)

[VVD]

PR submitted. Via GitHub web interface only ;)

Thanks!

Waiting release now.