search

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
108 stars 64 forks source link

Add possibility to login against mysql/mariadb #33

Closed collinwebdesigns closed 5 years ago

collinwebdesigns commented 5 years ago

Signed-off-by: Oscar Krause oscar.krause@collinwebdesigns.de

violoncelloCH commented 5 years ago

thank you for your contribution! the code generally looks good to me, however I'm not sure if we should implement this functionality into user_external because there already exist two apps doing this (https://apps.nextcloud.com/apps/user_sql and https://apps.nextcloud.com/apps/user_backend_sql_raw) probably in a better way (more functionality). what do you think @nextcloud/user_external @MorrisJobke @nickvergessen ?

nickvergessen commented 5 years ago

I agree

MorrisJobke commented 5 years ago

I would say, that this should be done inside one of the user sql backends. 👍