search

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
108 stars 64 forks source link

Implements error handling for imap errors #11 #34

Closed anojht closed 5 years ago

anojht commented 5 years ago

Prints IMAP errors and alerts to the nextcloud log. See #11 closes #11

violoncelloCH commented 5 years ago

thank you for your contribution!

DCO is failing because the commit is not signed-off @anojht could you please sign your commit? - see https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work can be done with git commit --amend -s for the last commit and then git push -f to push the changed commit back to github...

anojht commented 5 years ago

@violoncelloCH the commits have been signed

violoncelloCH commented 5 years ago

thank you @anojht please review @nextcloud/user_external

cweiske commented 5 years ago

Shouldn't the log messages only be created if there are really errors or warnings? The code looks as if the log entries are always generated.

violoncelloCH commented 5 years ago

good point @cweiske

anojht commented 5 years ago

@violoncelloCH I have stored the errors and checked for empty list, before printing.

MorrisJobke commented 5 years ago

@violoncelloCH Feel free to merge this here. 1 review for apps is fine. Only for the server part we need 2 👍

violoncelloCH commented 5 years ago

@MorrisJobke I just thought another review from one of you could be good, because I'm not that experienced yet... but I tested it once more and think it's fine, so merging it...