Add Prosody XMPP MySQL DB authentication

[sebastiansterk]

This pull request contains an implementation for authentication against a Prosody XMPP MySQL database. The user can login to a nextcloud instance with his XMPP ID + password.

[violoncelloCH]

Hi @sebastiansterk thank you for your contribution! However I've got some considerations first:

• your authentication works against an other database -- see that we rejected PR #33, which wanted to implement a general functionality like that; the reason is, that there exist two other apps allowing authentication against DBs
• your authentication method looks very specific... it only works if it's a "prosody" xmpp server and the admin has access to its database, right? how common is prosody? how many instances and users would possibly use this implementation? (as the user_external app is a rather general and basic authentication provider, I would prefer a more general approach to authenticate against the xmpp server directly, so it would work with all xmpp servers)
• an other point is that I don't have a (prosody) xmpp server, so I can't really test this... would you be willing to help me test new releases of the user_external app?

so what are your thoughts and arguments? :smile:

[sebastiansterk]

1) this is only for prosody's mysql database 2) it is specific, as mentioned this is an authentication against a prosody mysql database incl. hmac_sha1 check - you just need a db user that has access to the prosody db. how many users and instances? Idk, in the xmpp ecosystem there are two big xmpp servers: ejabberd and prosody. Prosody admins can use this plugin so all users can use their xmpp account to use the nextcloud instance. A authentication against the xmpp service itself would be better. This is just a very simple and minimalistic solution w/o huge xmpp authentication classes. 3) yes

[violoncelloCH]

@sebastiansterk thank you for explaining! @nextcloud/user_external @MorrisJobke @nickvergessen what do you think?

[MorrisJobke]

I can fully understand both sides here, but this should be totally up to the maintainer of the app. I don't have a real opinion here nor would I force anybody here to some way.

There is also the user_sql app that also has similar capabilities.

[violoncelloCH]

So I think if @sebastiansterk is willing to help testing new releases I'm fine with merging this... :)

[violoncelloCH]

thank you @sebastiansterk please review @nextcloud/user_external

[violoncelloCH]

@sebastiansterk there are some conflicts... could you rebase your work on current master?

[sebastiansterk]

@sebastiansterk there are some conflicts... could you rebase your work on current master?

Done, but Travis build failed because of: The command "sudo apt-get -qq update" failed and exited with 100 during . Is there a way to run that job again?

[violoncelloCH]

Is there a way to run that job again?

restarted the job...

a more elegant way than merging the master branch into the PR branch would have been to use git rebase... could you revert the merge commit and do a rebase in command line, so we don't have this unwanted extra commit in the git history?

[violoncelloCH]

thank you @sebastiansterk

[sebastiansterk]

Is there a date planned when it will be merged?

[violoncelloCH]

I would have liked to have a review from someone who has more php experience than me, because I also can't test this without a Prosody setup. Maybe @ChristophWurst would have the time to take a look at this as we already talked about this during the Contributor Week?

[violoncelloCH]

ahh, and again, it would be nice if you @sebastiansterk could resolve conflicts with a git rebase instead of merging master into this branch.

[violoncelloCH]

thank you @ChristophWurst !

[violoncelloCH]

thank you @sebastiansterk for the code styling! :rocket: what about the merge commit?

[ChristophWurst]

I would suggest to squash the commits into one to keep the change atomic

[violoncelloCH]

@ChristophWurst ahh, that's an idea however Github tells me that squashing is not enabled for this repository... can you do this?

[ChristophWurst]

Just do it locally and force push the changes back :wink:

[violoncelloCH]

huh, never done this... how does this work; I can't push to this PR's branch, because it's not in the nextcloud repo...? so do I need to push to an other branch and then merge this one?

[ChristophWurst]

You should be able to. Just add the fork as new remote.

[ChristophWurst]

Something like

git remote add sebastiansterk git@github.com:sebastiansterk/user_external.git
... usual rebase magic ...
git push sebastiansterk/master --force

[violoncelloCH]

yay, it worked! :rocket: thank you @ChristophWurst for the help! and thank you @sebastiansterk for the contribution!

[violoncelloCH]

@sebastiansterk as you are in the Nextcloud organisation since a few days :rocket: I also invited you to the user_external group/team so it's easier to keep you up to date about what's happening in user_external :) It also means that you can now review PRs and create branches in Nextclouds repositories directly (for easier collaboration)... I would also love to see future contributions :)

[sebastiansterk]

Thank you @violoncelloCH :)