nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
108 stars 64 forks source link

Cleanly close imap connection #71

Closed brknkfr closed 5 years ago

brknkfr commented 5 years ago

I'm using user_external together with imapproxy (imapproxy.org) which always logged 'IMAP_Line_Read(): connection closed prematurely.' regularly, because user_external doesn't close imap connection cleanly.

violoncelloCH commented 5 years ago

hi @brknkfr, thanks for your contribution!

however DCO is failing because the commit is not signed-off @brknkfr could you please sign your commit? - see https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work can be done with git commit --amend -s for the last commit and then git push -f to push the changed commit back to github...

brknkfr commented 5 years ago

... did a clean pull request: https://github.com/nextcloud/user_external/pull/75

violoncelloCH commented 5 years ago

thanks!