search

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
109 stars 65 forks source link

Fix Querybuilder to find Users that have difference uid from displayName #74

Closed lephisto closed 5 years ago

lephisto commented 5 years ago

Fixes #73 Fixes #77

violoncelloCH commented 5 years ago

thank you for the fix! could you do a signoff on the commit? (see instructions below)

DCO is failing because the commit is not signed-off @ could you please sign your commit? - see https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work can be done with git commit --amend -s for the last commit and then git push -f to push the changed commit back to github...

lephisto commented 5 years ago

Signed.. sorry it was like 3am, when fixing this :(

violoncelloCH commented 5 years ago

no problem! thanks for adding the sign-off! I'll test this as soon as I'll find some time...

violoncelloCH commented 5 years ago

hmm this doesn't seem to fix the issue for me... I still have to enter the full uid to bring up the user :/ I also discovered that there is a new issue with user search (in user management and during sharing) since NC 16 users are not found by display name any more...

lephisto commented 5 years ago

Thanks for merging. Helps a ton for future updates - less manual fixes .)

violoncelloCH commented 5 years ago

yeah thank you for figuring this out and fixing it :)