search

nextcloud / user_external

👥 External user authentication methods like IMAP, SMB and FTP
https://apps.nextcloud.com/apps/user_external
108 stars 64 forks source link

users not found by display name #77

Closed violoncelloCH closed 5 years ago

violoncelloCH commented 5 years ago

Steps to reproduce

  1. search for a user by display name (either in sharing dialogue or in user management)

Expected behaviour

users should be found by display name, not only by username/uid

Actual behaviour

you can't find users by display name anymore

It seems there has been either something changed in Nextcloud for 16 regarding the user search or it could also be related to the changes done to the sql queries in #30 @nickvergessen, as you've done most of the changes in #30, do you have an idea what's going wrong here? or do you know who could be able to help me out here? because I sadly don't (yet) have much experience with databases nor with how the Nextcloud user managment is working...

What is called when a user search / lookup is done in NC?

73 could be related to this one as well (users are only found when sharing if the complete username is entered)... so these two together make for a horrible experience when one want's to share to users from user_external :/

violoncelloCH commented 5 years ago

so I had the time to test this and can now say, that this (as well as #73) is coming from the changes done in #30, most likely the changed database queries... I just checked out one commit before the merge commit of #30 and there it's working even with the latest master of server

violoncelloCH commented 5 years ago

okay I've been wrong with my test of @lephisto 's PR #74 which already fixes this; see https://github.com/nextcloud/user_external/pull/74#pullrequestreview-244603435