search

nextcloud / user_saml

:lock: App for authenticating Nextcloud users using SAML https://apps.nextcloud.com/apps/user_saml
https://portal.nextcloud.com/article/configuring-single-sign-on-10.html
GNU Affero General Public License v3.0
96 stars 76 forks source link

#187 Populate avatar from SAML attribute #740

Open RickBruyninckx opened 1 year ago

RickBruyninckx commented 1 year ago

This PR addresses #187.

The code is coppied from Lumrenion but his PR seems stale so I'm giving it a shot.

In admin configuration, a new configuration field avatar_mapping is added. If avatar_mapping configuration field is not empty, the user wont be able to upload an image in the nextcloud profile settings The avatar_mapping field holds a publicly available URL to the profile image of the user. As usual, the image will be downloaded to nextcloud when the user logs in via user_saml.

phauch commented 10 months ago

Can we expect this to be merged (soon)? 🤔

RickBruyninckx commented 10 months ago

Can we expect this to be merged (soon)? 🤔

I don't expect it to happen anymore... This PR was created 211 days ago but I don't think anyone is willing to review it.

phauch commented 10 months ago

Can we expect this to be merged (soon)? 🤔

I don't expect it to happen anymore... This PR was created 211 days ago but I don't think anyone is willing to review it.

Sad.

blizzz commented 1 month ago

Sorry. I was actually starting to look into it quite a while ago… but don't have a good setup for smoke testing it. Generally the code looked fine iirc. Have to revisit.