nextcloud / user_saml

:lock: App for authenticating Nextcloud users using SAML https://apps.nextcloud.com/apps/user_saml
https://portal.nextcloud.com/article/configuring-single-sign-on-10.html
GNU Affero General Public License v3.0
96 stars 75 forks source link

Group migration does not take over memberships #862

Closed blizzz closed 4 months ago

blizzz commented 4 months ago

In https://github.com/nextcloud/user_saml/blob/master/lib/Jobs/MigrateGroups.php#L89-L113 we move the group id from the local backend's table to the SAML backend's table. But the members are being ignored. They stay in oc_group_user while the new reference table after the migration is oc_user_saml_group_members. A migration might be kicked off from the login of a single users, resulting in other members "loosing" their membership until their next login.