search

nextcloud / user_saml

:lock: App for authenticating Nextcloud users using SAML https://apps.nextcloud.com/apps/user_saml
https://portal.nextcloud.com/article/configuring-single-sign-on-10.html
GNU Affero General Public License v3.0
96 stars 75 forks source link

fix(Controller): make redirectUrl optional #905

Closed blizzz closed 1 week ago

blizzz commented 1 week ago

… so that calling it does not break when doing it manually and the redirect parameter is lost.

The empty string is also the fallback if it the redirect target was not specified in normal operations.

blizzz commented 1 week ago

Failing tests are PHP 8.4 related and due to the SAML lib that uses deprecated implicit nullable types. I.e. not relevant to this fix.

blizzz commented 1 week ago

💣 🏋️

:question: I don't think I am getting it. Slim Pickens does the right thing and carries the bomb to hell?