search

nextcloud / user_sql

🔒 App for authenticating Nextcloud users using SQL
GNU Affero General Public License v3.0
66 stars 33 forks source link

Error: Only variables should be assigned by reference at /apps/user_sql/lib/Repository/UserRepository.php#174 #162

Open tacruc opened 3 years ago

tacruc commented 3 years ago

While updating or changing user passwords, I get this error, which is quite nasty as it logs the password in a plain version.

[PHP] Error: Error: Only variables should be assigned by reference at /srv/www/htdocs/nextcloud/apps/user_sql/lib/Repository/UserRepository.php#174 at <<closure>>

0. /srv/www/htdocs/nextcloud/apps/user_sql/lib/Repository/UserRepository.php line 174
   OC\Log\ErrorHandler::onError(8, "Only variables  ... e", "/srv/www/htdocs ... p", 174, {user: OCA\UserS ... e})
1. /srv/www/htdocs/nextcloud/apps/user_sql/lib/Backend/UserBackend.php line 534
   OCA\UserSQL\Repository\UserRepository->save(OCA\UserSQL\Mode ... "}, 4)
2. /srv/www/htdocs/nextcloud/lib/private/User/User.php line 296
   OCA\UserSQL\Backend\UserBackend->setPassword("C1DB8356-81B5-4B60-9C65-3C5BB764B8D2", "IchgehemitAndreasaufdenFatlar")
3. /srv/www/htdocs/nextcloud/apps/settings/lib/Controller/ChangePasswordController.php line 111
   OC\User\User->setPassword("IchgehemitAndreasaufdenFatlar")
4. /srv/www/htdocs/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 218
   OCA\Settings\Controller\ChangePasswordController->changePersonalPassword("PASSWORD", "IchgehemitAndreasaufdenFatlar")
5. /srv/www/htdocs/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 127
   OC\AppFramework\Http\Dispatcher->executeController(OCA\Settings\Con ... {}, "changePersonalPassword")
6. /srv/www/htdocs/nextcloud/lib/private/AppFramework/App.php line 157
   OC\AppFramework\Http\Dispatcher->dispatch(OCA\Settings\Con ... {}, "changePersonalPassword")
7. /srv/www/htdocs/nextcloud/lib/private/Route/Router.php line 302
   OC\AppFramework\App::main("OCA\\Settings\\ ... r", "changePersonalPassword", OC\AppFramework\ ... {}, {_route: "settin ... "})
8. /srv/www/htdocs/nextcloud/lib/base.php line 993
   OC\Route\Router->match("/settings/personal/changepassword")
9. /srv/www/htdocs/nextcloud/index.php line 37
   OC::handleRequest()

POST /index.php/settings/personal/changepassword
from 10.0.8.3 by C1DB8356-81B5-4B60-9C65-3C5BB764B8D2 at 2021-07-26T09:53:15+00:00