search

nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
97 stars 55 forks source link

Integration Djvu support #124

Open ptah-alexs opened 5 years ago

ptah-alexs commented 5 years ago

Please integrate support of djvu files.

https://github.com/RussCoder/djvujs https://djvu.js.org

violoncelloCH commented 5 years ago

That sounds like an idea for a nextcloud app. Why don't you write one for this use case? :) @ptah-alexs

ptah-alexs commented 5 years ago

I'm not a skilled programmer.

violoncelloCH commented 5 years ago

You could just try :) Or we will just leave this one here for someone else to pick up. I just don't think that the core team has got time to do something like this. That's why Nextcloud is modular.

skjnldsv commented 5 years ago

Moved to the viewer app. @jancborchardt shall we integrate stuff into the default viewer or try to create another app?

jancborchardt commented 5 years ago

While separation is nice, this should be part of the viewer app like many other filetypes (like the photosphere app, or files_3d, camera RAW, etc). People don’t want to see and/or enable viewers for every single filetype, it should just work. :)

(We made this mistake with the "Social sharing" apps which have 5 different apps to enable for all the different platforms. This is not good, it should just be one app with settings to pick if you want to disable some platforms from showing.)

skjnldsv commented 5 years ago

Proposal: If the app do more than just registering a view on the viewer, then we need a dedicated app. Otherwise, let's add this here?

jancborchardt commented 5 years ago

Yup! And the ideal case should be that any of these apps are just registering a view and it just works. :)

skjnldsv commented 5 years ago

are just registering a view and it just works

what do you mean by that?

jancborchardt commented 5 years ago

That currently some of these apps which are essentially just viewers for specific file types (like the https://github.com/nextcloud/files_photospheres by @R0Wi) have their own app. Instead they could be integrated into the viewer. Gestures like dragging to move and pinch/click to zoom could simply work. :)

skjnldsv commented 5 years ago

Well, if they're just registering a view, let's integrate them on the viewer app directly, no? That's what I meant by https://github.com/nextcloud/viewer/issues/124#issuecomment-498647910

The example you gave is a nice one, because it doesn't seems to be only a file viewer, the files_photospheres app also have some kind of php script and stuff behind, which I don't know about :)

jancborchardt commented 5 years ago

Well, if they're just registering a view, let's integrate them on the viewer app directly, no?

Yes.

The example you gave is a nice one, because it doesn't seems to be only a file viewer, the files_photospheres app also have some kind of php script and stuff behind, which I don't know about :)

The question is if that is necessary. And even if it is, as a user I don't care if there's PHP involved. ;)

skjnldsv commented 5 years ago

The question is if that is necessary. And even if it is, as a user I don't care if there's PHP involved. ;)

Don't go this way :) I'm telling this because there might be some ui or setting in the files_photospheres app that I am not aware of. If that's the case, this will not be integrated into viewer.

EchedelleLR commented 1 year ago

Any update into this?