nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
97 stars 55 forks source link

Cannot save image chances made in the editor #1847

Open Cwpute opened 1 year ago

Cwpute commented 1 year ago

( As reported in https://github.com/nextcloud/viewer/issues/1915 with some additions)

Describe the bug: Changes made to most image files cannot be saved: upon saving, the editor hangs and does not save. The problem does not occur with photos with small file size (e.g. 250 kb), but with photos with file size of e.g. 2.5 MB. This problem occurs only in Firefox, but not e.g. in Chromium.

Steps to reproduce the behavior: Photos -> Editor -> Adjust -> Save also possible from Files -> open any photo -> Pen edit button -> Adjust -> Save same with the NC Memories app

Expected behavior: Changes should be saved accordingly. The editor should at least ackowledge it's encountering an issue and inform the user it cannot save.

Describe alternatives you've considered: When I use Chromium instead of Firefox, the problem does not occur.

Desktop (as provided by original topic creator: NC Hub 3, 25.02 (hosted), Photos, Version 2.0.1., Firefox 107.0.1 (64-Bit) Windows 10Pro 21H2 Chromium Version 105.0.5195.54 (Official Build) (64-Bit)

Console logs: @avephill

Exception { name: "NS_ERROR_FAILURE", message: "", result: 2147500037, filename: "http://127.0.0.1:8080/custom_apps/memories/js/memories-…ilerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd", lineNumber: 2, columnNumber: 0, data: null, stack: "setHeight@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:67982\nsetSize@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:68091\npn@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:68491\n_buildDOM@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:107471\npr@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:98556\nclone@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:84636\nclone@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:93657\nclone@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:99724\n67420/bu/<@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:262890\nI@http://127.0.0.1:8080/custom_apps/memories/js/memories-vendors-node_modules_filerobot-image-editor_lib_index_js.js?v=8ed69006cff1c8fd25dd:2:522325\n" }

@ocroquette

Exception { name: "NS_ERROR_FAILURE", message: "", result: 2147500037, filename: "https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0", lineNumber: 2, columnNumber: 0, data: null, stack: " setHeight@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1515935 setSize@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1516044 vA@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1516444 _buildDOM@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1555424 vC@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1546509 clone@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1532589 clone@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1541610 clone@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1547677 xD/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1710979 O@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1971357 setTimeout handler*P@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1971538 L@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1971695 onKeyUp@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1969596 Ie@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:832336 $e@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:832490 4448/Mr/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:852372 Mr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:852466 Rr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:852882 4448/Vr/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:858320 cu@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:921642 Le@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:831469 Vr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:854174 Zt@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:838585 Gt@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:838367 EventListener.handleEvent*qr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853679 Ur@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853078 4448/Hr/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853244 Hr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853188 Zs@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:904148 Cu@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:924616 Au@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:924498 yu@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:924367 vu@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:924228 uu@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:921371 qo@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:862318 4448/ou/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:918972 VoidFunction*ou@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:918946 ru@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:918410 rs@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:883804 F@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1971841 tR/<.onClick<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1894295 Ie@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:832336 $e@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:832490 4448/Mr/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:852372 Mr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:852466 Rr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:852882 4448/Vr/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:858320 cu@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:921642 Le@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:831469 Vr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:854174 Zt@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:838585 Gt@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:838367 EventListener.handleEvent*qr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853679 Ur@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853078 4448/Hr/<@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853244 Hr@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:853188 4448/t.createRoot@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:943129 e@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:2063035 mounted@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:2070551 Pt@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1172857 sn@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1177729 insert@https://mydomain.fake/nextcloud/apps/viewer/js/viewer-main.js?v=e07e16b1-0:2:1181468 "}

@TomyMMX

Uncaught 
Exception { name: "NS_ERROR_FAILURE", message: "", result: 2147500037, filename: "https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2", lineNumber: 2, columnNumber: 0, data: null, stack: "setHeight@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1515935\nsetSize@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1516044\nvA@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1516444\n_buildDOM@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1555424\nvC@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1546509\nclone@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1532589\nclone@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1541610\nclone@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1547677\nxD/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1710979\nO@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1971357\nsetTimeout handler*P@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1971538\nL@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1971695\nIe@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:832336\n$e@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:832490\n4448/Mr/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:852372\nMr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:852466\nRr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:852882\n4448/Vr/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:858320\ncu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:921642\nLe@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:831469\nVr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:854174\nZt@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:838585\nGt@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:838367\nEventListener.handleEvent*qr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:853679\nUr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:853078\n4448/Hr/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:853244\nHr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:853188\nZs@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:904148\nCu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:924616\nAu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:924498\nyu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:924367\nvu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:924228\nuu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:921371\nqo@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:862318\n4448/ou/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:918972\nVoidFunction*ou@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:918946\nru@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:918410\nrs@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:883804\nF@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1971841\ntR/<.onClick<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:1894295\nIe@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:832336\n$e@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:832490\n4448/Mr/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:852372\nMr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:852466\nRr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:852882\n4448/Vr/<@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:858320\ncu@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:921642\nLe@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:831469\nVr@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:854174\nZt@https://cloud.fakedomain.com/apps/viewer/js/viewer-main.js?v=efb0496e-2:2:838585\n" }
viewer-main.js:2
perkyquirky commented 11 months ago

I too am having this issue. Present with NC Memories but not in NC Photos.

NC Photos: Saves on edit. NC Memories: Fails to save.

Though mine does not hang, I just get an error message in the top right hand side of the page saying Error: Unable to save.

Desktop: Fedora 39 Firefox 120.0 NC 27.1.3 self hosted

Have not tested Chromium based browser.