nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
97 stars 55 forks source link

[Bug]: Preview of image is not updated after the changes made #2298

Open ostasevych opened 1 year ago

ostasevych commented 1 year ago

⚠️ This issue respects the following points: ⚠️

Bug description

After editing an image with the help of internal tools for editing, saving it and re-opening the image shown in the preview as it hasn't been changed. Though in fact it is changed.

Steps to reproduce

  1. Open image in webUI of NC
  2. Make some modifications, eg, cut, change contrast
  3. Click Save
  4. Close
  5. Open again and observe that there are no changes.
  6. Click edit and observe that changes have been applied.
  7. Open the image locally and observe that the changes have been applied.

Expected behavior

The preview is immediately updated after the changes have been applied after editing.

Installation method

Community Manual installation with Archive

Nextcloud Server version

26

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.0

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Updated from a MINOR version (ex. 22.1 to 22.2)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "mytld.local",
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "26.0.4.2",
        "overwrite.cli.url": "https:\/\/mytld.local\/",
        "htaccess.RewriteBase": "\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "UA",
        "default_locale": "uk_UA",
        "default_language": "uk",
        "allow_user_to_change_display_name": false,
        "auth.webauthn.enabled": false,
        "remember_login_cookie_lifetime": 1296000,
        "session_lifetime": 21600,
        "session_relaxed_expiry": false,
        "session_keepalive": false,
        "auto_logout": false,
        "skeletondirectory": "\/media\/server\/ncdata\/skeleton",
        "maintenance": false,
        "enable_previews": true,
        "preview_max_x": "2048",
        "preview_max_y": "2048",
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 6379
        },
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "app_install_overwrite": [
            "documentserver_community",
            "twofactor_admin",
            "files_trackdownloads",
            "twofactor_webauthn",
            "files_fulltextsearch",
            "fulltextsearch_elasticsearch",
            "fulltextsearch",
            "group_default_quota",
            "extract",
            "bookmarks_fulltextsearch",
            "files_fulltextsearch_tesseract",
            "twofactor_gateway",
            "ransomware_protection",
            "webhooks",
            "apporder"
        ],
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpsecure": "ssl",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "465",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "theme": "",
        "logtype": "file",
        "logfile": "\/var\/log\/nextcloud.log",
        "loglevel": 3,
        "activity_use_cached_mountpoints": true,
        "trashbin_retention_obligation": "auto, 30",
        "logtimezone": "Europe\/Kyiv",
        "profile.enabled": false,
        "onlyoffice": {
            "verify_peer_off": true,
            "jwt_secret": "secret",
            "jwt_header": "AuthorizationJwt"
        },
        "enabledPreviewProviders": [
            "OC\\Preview\\MP3",
            "OC\\Preview\\TXT",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\OpenDocument",
            "OC\\Preview\\Krita",
            "OC\\Preview\\Imaginary"
        ],
        "jpeg_quality": "60",
        "preview_imaginary_url": "http:\/\/localhost:9000",
        "twofactor_enforced": "true",
        "SIGNAL_CLI_DBUS_REST_API_ACCOUNT": "***REMOVED SENSITIVE VALUE***",
        "allow_local_remote_servers": true,
        "twofactor_enforced_groups": [
            "admin"
        ],
        "twofactor_enforced_excluded_groups": []
    }
}

List of activated Apps

- activity: 2.18.0
  - calendar: 4.4.3
  - cloud_federation_api: 1.9.0
  - comments: 1.16.0
  - contacts: 5.3.2
  - dav: 1.25.0
  - end_to_end_encryption: 1.12.5
  - external: 5.1.0
  - extract: 1.3.6
  - federatedfilesharing: 1.16.0
  - files: 1.21.1
  - files_confidential: 1.0.3
  - files_downloadactivity: 1.16.0
  - files_fulltextsearch: 26.0.0
  - files_fulltextsearch_tesseract: 27.0.0
  - files_linkeditor: 1.1.16
  - files_pdfviewer: 2.7.0
  - files_rightclick: 1.5.0
  - files_sharing: 1.18.0
  - files_trashbin: 1.16.0
  - files_versions: 1.19.1
  - files_zip: 1.4.0
  - firstrunwizard: 2.15.0
  - flow_notifications: 1.6.0
  - fulltextsearch: 26.0.0
  - fulltextsearch_elasticsearch: 26.0.0
  - group_everyone: 0.1.13
  - groupfolders: 14.0.3
  - holiday_calendars: 0.3.0
  - logreader: 2.11.0
  - lookup_server_connector: 1.14.0
  - notes: 4.8.1
  - notifications: 2.14.0
  - oauth2: 1.14.1
  - onlyoffice: 7.8.0
  - password_policy: 1.16.0
  - privacy: 1.10.0
  - provisioning_api: 1.16.0
  - serverinfo: 1.16.0
  - settings: 1.8.0
  - tasks: 0.15.0
  - text: 3.7.2
  - theming: 2.1.1
  - twofactor_admin: 4.2.0
  - twofactor_backupcodes: 1.15.0
  - twofactor_gateway: 0.20.0
  - twofactor_reminder: 1.0.0
  - twofactor_totp: 8.0.0
  - updatenotification: 1.16.0
  - viewer: 1.10.0
  - workflow_script: 1.11.2
  - workflowengine: 2.8.0

Nextcloud Signing status

Technical information
=====================
The following list covers which files have failed the integrity check. Please read
the previous linked documentation to learn more about the errors and how to fix
them.

Results
=======
- fulltextsearch
    - INVALID_HASH
        - css/fulltextsearch.css
- fulltextsearch_elasticsearch
    - INVALID_HASH
        - lib/Platform/ElasticSearchPlatform.php
- twofactor_gateway
    - INVALID_HASH
        - lib/Service/Gateway/Signal/Gateway.php

Raw output
==========
Array
(
    [fulltextsearch] => Array
        (
            [INVALID_HASH] => Array
                (
                    [css/fulltextsearch.css] => Array
                        (
                            [expected] => ca9e80c60e05bedd6e31244822d5bb542c4bbd52ab8d3fc2f9e5e9a2ad76fc26268436a79be81acb4e8f701e2ac055c191a214549ed26a5817d22fdd40c63fc3
                            [current] => 9cfdd3a446d227fdebf6faae02bb8616cacf412a944c22538ccefec1ee16f331f0405f51505b83c0e0571f5d80cfc49d26e08f53fcc7fa1faca4f2e47d8d2489
                        )

                )

        )

    [fulltextsearch_elasticsearch] => Array
        (
            [INVALID_HASH] => Array
                (
                    [lib/Platform/ElasticSearchPlatform.php] => Array
                        (
                            [expected] => b57ec13e2d20ed573011d005f738f79ed16e8e28cce6a805d5a30c842473c341149db583ae5df91de0492d56d3c3a96bc06de92803fe95b3220c009191a73d96
                            [current] => 588ad533420ee014a7aaef31ca66b8ae9d9e9c7d1b372fe5b44e30b338a376d8c75aa66d0e68956055b9e158609fb6c23384298a91c8f9d323feade512d0abd6
                        )

                )

        )

    [twofactor_gateway] => Array
        (
            [INVALID_HASH] => Array
                (
                    [lib/Service/Gateway/Signal/Gateway.php] => Array
                        (
                            [expected] => 3127ada11e34a1c33fcc117ffeefc0ab317e1f66312692c21c69c1b6ac82ddc0a5b79aa733eb1d3ad496f746218d1241b1ea9a63e514efe9e0534b8d0529079a
                            [current] => 1a5d14434fceed22644762fb25590fd838f8b8f9c51a034070562c2fcf3640976a9bd5b7d98920fe5dd91da55cb67731e03a2615a8199729911c6262e7932932
                        )

                )

        )

)

Nextcloud Logs

No response

Additional info

No response

kesselb commented 1 year ago

Are you sure the preview is not updated, or is the preview still cached by your browser?

ostasevych commented 1 year ago

Are you sure the preview is not updated, or is the preview still cached by your browser?

Ehmm, how to get know that? And what to do?

UPD After forced refreshing of the page it updates! So, the right logic should be the following:

Otherwise it is not obvious whether the changes have been applied at all.