nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
91 stars 51 forks source link

Properly save old route when opening the viewer #2322

Closed artonge closed 1 month ago

artonge commented 1 month ago

I guess the params and query properties of the route are updated and not replaced on route change, so we were losing the previous state.

artonge commented 1 month ago

/backport to stable29

artonge commented 1 month ago

/backport to stable28

artonge commented 1 month ago

@skjnldsv, I don't have admin rights to bypass the unrelated failing Cypress test

susnux commented 1 month ago

I don't have admin rights to bypass the unrelated failing Cypress test

They are not really unrelated. Sometime ago a PR was merged without updating the snapshots. You need to update the snapshots, then it should be good again.

PS: Yes probably a nextcloud-vue issue but tests are doing what they should do: Fail if something is wrong :)

artonge commented 1 month ago

Updating snapshots did not help here. Not sure why they differ in the CI, they have some bold text. In any case, this is not related at all to the change.

susnux commented 1 month ago

Updating snapshots did not help here. Not sure why they differ in the CI, they have some bold text. In any case, this is not related at all to the change.

Have generated them locally? I do not think this will work because of font issues. Best way is to download the snapshots from the CI workflow and use them.

backportbot[bot] commented 1 month ago

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2322/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 09d754a8 80a08547

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2322/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] commented 1 month ago

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2322/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 09d754a8 80a08547

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2322/stable29

Error: Failed to push branch backport/2322/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

susnux commented 1 month ago

/backport 09d754a8355a40c4497bef8ba52fcf0abeea3873 to stable28

susnux commented 1 month ago

/backport 09d754a8355a40c4497bef8ba52fcf0abeea3873 to stable29

backportbot[bot] commented 1 month ago

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2322/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 09d754a8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2322/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

artonge commented 4 weeks ago

/backport 09d754a8355a40c4497bef8ba52fcf0abeea3873 to stable28

backportbot[bot] commented 4 weeks ago

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2322/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 09d754a8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2322/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.