Open setnes opened 4 years ago
skjnldsv
commented
4 years ago Hey! Thanks for your report! We aim to simplicity and don't want to add options for such variations of the software. I feel like the current background is pretty ok to me, but maybe you think we should darken it a bit. Can you provide an example of opacity that would fit your need?
cc @jancborchardt :)
jancborchardt
commented
4 years ago Currently it’s at rgba(0,0,0,0.92), how about we try with rgba(0,0,0,0.97) for some time?
It’s much darker, but still gives a slight bit of context.
setnes
commented
4 years ago Why does it have to be transparent at all? The only thing that should be visible is the photo/video/etc being viewed. Everything else is a distraction.
setnes
commented
4 years ago Maybe the background should be 100% black when the photo is viewed full screen and the transparency could be kept when not in full screen mode... just an idea.
jancborchardt
commented
4 years ago Yeah, I'm also fine with it being fully black.
@skjnldsv @juliushaertl I guess having it slightly transparent is another thing that is special for the first run wizard. And there it should also be more transparent than .92 opacity.
juliushaertl
commented
4 years ago Didn't we have 0.97 in the beginning and we decreased it because the context of the files app was totally missing?
skjnldsv
commented
4 years ago Didn't we have 0.97 in the beginning and we decreased it because the context of the files app was totally missing?
It's the other way around, it was too light, and we increased it twice: https://github.com/nextcloud/nextcloud-vue/pull/300
.7 => .85 => .92
jancborchardt
commented
4 years ago Yup, most of the changes are because we used the viewer for the first run wizard initially, and only then for pictures.
So they actually have slightly different requirements. :)
skjnldsv
commented
4 years ago @jancborchardt then I'll let you decide :)
jancborchardt
commented
4 years ago Hehe, then let’s do:
From there we can still see if we need to adjust anything. But the important thing is we separate these 2 distinct cases.
skjnldsv
commented
4 years ago What would be the default modal component value?
jancborchardt
commented
4 years ago Let’s use the same as first run wizard for now? We could maybe also then move the first run wizard / default value down again to a previous value of .85 or .7?
And then we have special cases for:
skjnldsv
commented
3 years ago What shall we do? It isn't that bad in the end? @jancborchardt
Is your feature request related to a problem? Please describe. I would like to be able to eliminate the transparency and use a black background. Seeing other files listed behind an image takes away from the image viewing experience. All emphasis should be on the photo, not other NextCloud files.
Describe the solution you'd like I would like a configuration option to set the viewer transparency percentage. If that's not possible, I'd like to just have a black background instead of a transparent one.
Describe alternatives you've considered The only alternative I have found is to disable this viewer and use the gallery viewer for photos. This might not be an option in the future depending on if the gallery app is changed to use this viewer instead of it's own.