nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
99 stars 54 forks source link

fix: Only remove openfile from route when closing the viewer #2493

Closed artonge closed 2 months ago

artonge commented 2 months ago

If the route has changed between when the Viewer was opened and then closed, then the 'old' route will be restored. But we probably want to keep the current route and only remove the openfile query.

More specifically, the fileid is removed from the route if it was not in the route when the Viewer was opened.

Can be triggered by changing the view and opening a file. Somehow not triggered every time. On load, the viewer is somehow triggered twice, a first time with fileid = undefined, and a second time with fileid = an actual file ID. So the bug is not really visible.

Here, it is visible on the third attempt to close the Viewer:

https://github.com/user-attachments/assets/5d486083-0bf8-4f46-82b0-e68882ea1dc3

Found this while working on https://github.com/nextcloud/server/pull/47920

skjnldsv commented 2 months ago

/compile rebase /

skjnldsv commented 2 months ago

/backport a4143a9 to stable30

skjnldsv commented 2 months ago

/backport a4143a9 to stable29

skjnldsv commented 2 months ago

/backport a4143a9 to stable28

backportbot[bot] commented 2 months ago

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/2493/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4143a9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2493/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] commented 2 months ago

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/2493/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4143a9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2493/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

backportbot[bot] commented 2 months ago

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/2493/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a4143a9

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2493/stable30

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

skjnldsv commented 2 months ago

hmmmm