nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
97 stars 55 forks source link

When clicking on photos with the same name the first photo will pop up #484

Closed okwes closed 10 months ago

okwes commented 4 years ago

Describe the bug When clicking on photos with the same name the first photo will pop up instead of the one clicked

To Reproduce Steps to reproduce the behavior:

  1. Have multiple photos with the same name in different folders
  2. In the photos app click on any of the ones with the same name. No matter which one you click on the same photo will pop up

Expected behavior The photo you click should pop up

skjnldsv commented 4 years ago

What do you mean, the same name?

okwes commented 4 years ago

yeah, so if I have xyz.jpg in one folder and again xyz.jpg in another when I click on anyone one of those the same one will always pop up

Here's a gif showing it: photo

skjnldsv commented 4 years ago

Thanks! :) It make sense yes, moving to the viewer repository!

skjnldsv commented 4 years ago

Btw @wes3161, I will need your browser console log to investigate this issue. Open your console, reload your page and/or do the action leading to this issue and copy/paste the log in this thread.

How to access your browser console (Click to expand) # Chrome - Press either CTRL + SHIFT + J to open the “console” tab of the Developer Tools. - Alternative method: 1. Press either CTRL + SHIFT + I or F12 to open the Developer Tools. 2. Click the “console” tab. # Safari - Press CMD + ALT + I to open the Web Inspector. - See Chrome’s step 2. (Chrome and Safari have pretty much identical dev tools.) # IE9 1. Press F12 to open the developer tools. 2. Click the “console” tab. # Firefox - Press CTRL + SHIFT + K to open the Web console (COMMAND + SHIFT + K on Macs). - or, if Firebug is installed (recommended): 1. Press F12 to open Firebug. 2. Click on the “console” tab. # Opera 1. Press CTRL + SHIFT + I to open Dragonfly. 2. Click on the “console” tab.
okwes commented 4 years ago

Console Logs:

Content Security Policy: The page’s settings blocked the loading of a resource at inline (“script-src”). content-script.js:40:65
JQMIGRATE: Migrate is installed, version 1.4.1 jquery-migrate.min.js:2:551
Proxying an event bus of version 1.1.2 with 0.2.1 ProxyBus.js:65:14
Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20 globals.js:66:15
Notifications permissions granted App.vue:242
OCA.Files.Sidebar initialized Sidebar.js:37:10
Handlebars is deprecated: please ship your own, this will be removed in Nextcloud 20 2 globals.js:66:15
Proxying an event bus of version 1.1.2 with 0.2.1 ProxyBus.js:65:14
Proxying an event bus of version 1.1.2 with 0.2.1 ProxyBus.js:65:14
OCA.Sharing.ShareSearch initialized ShareSearch.js:33:10
OCA.Sharing.ExternalLinkActions initialized ExternalLinkActions.js:33:10
OCA.Viewer initialized Viewer.js:41:10
No OCA.Files app found, viewer is now in standalone mode Viewer.vue:287
This page uses the non standard property “zoom”. Consider using calc() in the relevant property values, or using “transform” along with “transform-origin: 0 0”. addStylesClient.js:220:17
TypeError: t.Files is undefined commentmodel.js:13:1
TypeError: OCA.Files.DetailTabView is undefined versionstabview.js:18:7
Current grid config 
Object { marginTop: Getter & Setter, marginW: Getter & Setter, count: Getter & Setter, gap: Getter & Setter, … }
GridConfig.js:39:10
Current grid config 
Object { marginTop: Getter & Setter, marginW: Getter & Setter, count: Getter & Setter, gap: Getter & Setter, … }
GridConfig.js:39:10
Loading next page 1 Timeline.vue:242
Loading next page 2 Timeline.vue:242
Opening viewer for file  /Audio Books/Just and Unjust Wars-A Moral Argument With Historical Illustrations/cover.jpg Viewer.vue:219
A files list have been provided. No folder content will be fetched. Viewer.vue:342
Opening viewer for file  /Audio Books/After Virtue, Third Edition/cover.jpg Viewer.vue:219
A files list have been provided. No folder content will be fetched. Viewer.vue:342
Opening viewer for file  /Audio Books/Saving Capitalism-For the Many, Not the Few/cover.jpg Viewer.vue:219
A files list have been provided. No folder content will be fetched. Viewer.vue:342
carlorodrigues commented 3 years ago

Is there any development on this bug?

k4r4c commented 2 years ago

Hi! I faced the same issue, on Firefox, with Nextcloud 22.2.2 installed on a Debian server. Similar logs are produced by the console:

Opening viewer for file  /xxx/IMG_0587.JPG Viewer.vue:276
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 248 globals.js:62:15
A files list have been provided. No folder content will be fetched. Viewer.vue:416
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 272 globals.js:62:15
Opening viewer for file  /xxx/IMG_0629.JPG Viewer.vue:276
jQuery is deprecated: The global jQuery is deprecated. It will be removed in a later versions without another warning. Please ship your own. 24 globals.js:62:15
A files list have been provided. No folder content will be fetched. Viewer.vue:416
adznon commented 2 years ago

Hi, I'm faced with the same issue.

Causing major issues int he family as they can see others photos, even though they have no access to the actual photo/folder

Any solution ?

MarcSeebold commented 2 years ago

Same here. Nextcloud's thumbnails show different photos, but when I click on "Download" I get the correct one.

Preview Generator: 5.0.0, Nextcloud 24.0.3

adznon commented 2 years ago

@skjnldsv

Has any progress being made on this, I am getting flack from family as people can see each others photos even though they dont have any access to those photos.

skjnldsv commented 2 years ago

@adznon nope, as you can see the labels have not changed and the milestone is clear

adznon commented 2 years ago

@skjnldsv Sorry didn't mean to come across condescending, Just getting grief from home around this issue.

Understand its on the backlog but still no progress or update for two years now.

Doesn't help me when one of my family saw a naked photo of there siblings girlfriend.... Considering it should of be protected as they are on different accounts with no sharing between them.

skjnldsv commented 2 years ago

@adznon No problem, I totally get it! The problem you mentioned is not related to this ticket, right? I don't see how the name opening would interfere with user sharing :thinking:

adznon commented 2 years ago

@skjnldsv

No its the same issue. The thumbnails show other peoples pictures.

i.e. User 1 has a photo called image1.jpg, user 2 has image1.jpg

User two will see the thumbnail from user 1's photo even though user 2 has no permission to user 1's files, although when clicking on it it will open the correct photo.

skjnldsv commented 2 years ago

User two will see the thumbnail from user 1's photo even though user 2 has no permission to user 1's files, although when clicking on it it will open the correct photo.

Whaaaat? We store previews by the fileId, it's not possible. Can you reliably reproduce the issue ? With new users ? Are they sharing data between the two?

This is very different from that issue. This one is about the same user having multiple photos across different folders with the same name opening them from Photos.

gody01 commented 1 year ago

Nextcloud 25.0.3 still has this bug.

Click on Thumbnail displays piscture from completely different folder with ame name as is thumbnail. Image URL, which one get with right click on thumbnail picture is OK and it displays correct image in new window.

This behaviour renders Photos part of Nextcloud completely unusable :(

unlucio commented 1 year ago

I've being driven nuts by this bug :( I rebuild the whole filesystem a number of times, changed disks, changed filesystem all together. Ran `occ files:scan --all" a number of times. Removed everything and re-added everything, tried all the possible nextcloud docker images I could find on docker hub. And instead it was this 3yo bug 😭

gody01 commented 1 year ago

I solved problem for me with renaming of all pictures to uniqid name (on linux, nextcloud client):

#
# Find pictures in form PICT*JPG and rename to uuid filename - for old scanned films ...
find . -name 'PICT*JPG' -print | while read FN; do echo $FN; mv -i $FN $(dirname $FN)/$(uuidgen).jpg ; done

It does put some burden to nextcloud server and client to sinchronize everything.

unlucio commented 1 year ago

well, of course you can rename all the files, but being able to handle same file names in different folders seems like a pretty basic requirement for a filesystem or an app dealing with files, doesn't it? For instance every time I use a gopro I start with an empty SD. The gopro using sequential file names means that every time I click on a preview some other picture opens up. I don't think that expecting to upload a folder with sequential names without going thru a rename ritual is an unreasonable expectation for something who's core feature is storing files.

gody01 commented 1 year ago

I don't argue with You. Just mentioned my workaround. I also use freshly formated SD for each old film and have same problem with bug.

unlucio commented 1 year ago

I don't argue with You. no worry mate, it wasn't to argue with you.

Sometimes a work around might be perceived as "good enough" to solve a problem, pushing the bugfix down the line. I was only trying to underline how whatever workaround doesn't seem like a good possible solution for a problem when it's part of the core functionality. That's all.

If you're happy renaming, by all means rename away to your heart content 😅

David-Rodriguez-cabrera commented 1 year ago

I just created a problem about this in the photos plugin and found this, there is still nothing, right?

carlorodrigues commented 11 months ago

Yup. As far as I know, this bug has not been addressed yet.