search

nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
97 stars 55 forks source link

Video play speed not accessible in Firefox 84 #686

Closed J0WI closed 3 years ago

J0WI commented 3 years ago

Video play speed button is covered by the volume slider. screenshot_nextcloud_player

Originally posted in https://github.com/nextcloud/viewer/issues/678#issuecomment-721263745

akoyaxd commented 3 years ago

I guess this issue would more belong here: https://github.com/nextcloud/files_videoplayer

Well, seems to be wrong.. ¯_(ツ)_/¯

skjnldsv commented 3 years ago

Nope, files_videoplayer is almost not used anymore. viewer handle this now

beardhatcode commented 3 years ago

This seems to be a bug in https://github.com/redxtech/vue-plyr/ .

I think this issue ( https://github.com/redxtech/vue-plyr/issues/266 ) is talking about the same problem. But the repo seems to be quite inactive since last November.

The same issue also crops up for me in https://redxtech.github.io/vue-plyr/.

beardhatcode commented 3 years ago

After some digging I found the root cause of this issue: vue-plyr is a small wrapper over sampotts/plyr. In version 3.6.3 of plyr, the CSS has been updated to fix the firefox issue. But this vue wrapper still has the old version in the lockfile.

https://github.com/redxtech/vue-plyr/blob/8077f1427ecf49802d5eb3423751eefac8bf5efe/yarn.lock#L6998-L7006

Dependabot has already made a PR to fix the issue: https://github.com/redxtech/vue-plyr/pull/318

beardhatcode commented 3 years ago

For future reference, the following css fixes the issue (source: https://github.com/sampotts/plyr/pull/2008/files ).

.plyr__controls__item.plyr__volume input[type="range"] {
    min-width: 0;
}
skjnldsv commented 3 years ago

I think this issue ( redxtech/vue-plyr#266 ) is talking about the same problem. But the repo seems to be quite inactive since last November.

I pinged the dev on twitter

skjnldsv commented 3 years ago

For future reference, the following css fixes the issue (source: sampotts/plyr#2008 (files) ).

Could you open a pr with a TODO to remind us to remove this temporary hack later on? :hugs: That would be awesome @beardhatcode :rocket:

beardhatcode commented 3 years ago

Oddly enough, I cannot reproduce this problem any more. @J0WI, are you still experiencing this?

I'm on Firefox 86.0.1 (64-bit)

J0WI commented 3 years ago

I cannot reproduce anymore with most recent versions of Firefox and Nextcloud.

skjnldsv commented 3 years ago

Lol, Great!

skjnldsv commented 3 years ago

Thank you both! :hugs: