search

nextcloud / viewer

🖼 Simple file viewer with slideshow for media
GNU Affero General Public License v3.0
91 stars 52 forks source link

Support for subtitles in the video player #879

Closed MeowMeowVenom closed 3 years ago

MeowMeowVenom commented 3 years ago

Is your feature request related to a problem? Please describe.

There is no option to view subtitles for a video file.

Describe the solution you'd like I would like to view subtitles for a video file.

Describe alternatives you've considered Maybe you can include plyr.io into nextcloud. It has wide-range of customisation features and subtitle options. https://github.com/sampotts/plyr

beardhatcode commented 3 years ago

Hi, @Rejected-Peice thank you for raising this issue, we are however using Plyr as video player. See: https://github.com/nextcloud/viewer/blob/3ef15a1e6e08545df85c3d1c6c19c24242caddd1/src/components/Videos.vue#L27-L53

To add captions to a HTML5 video we need to have vtt files containing the subtitles. One possible avenue to get support for subtitles is to auto select a vtt file by the same name. But that seems a bit clumsy to me and difficult to explain to new users.

@Rejected-Peice do you have a suggestion for a user-friendly way to allow users to select the subtitle file?

skjnldsv commented 3 years ago

do you have a suggestion for a user-friendly way to allow users to select the subtitle file?

The way we already stuff is if the fileNames are the same. usually modern videos players even use the format FILENAME.LANG.srt. We should most likely do the same as picking something is much more complicated.

skjnldsv commented 3 years ago

duplicate of https://github.com/nextcloud/viewer/issues/239