Fix Shellcheck warning

[enoch85]

Check warning on line 1228 in lib.sh GitHub Actions / Shellcheck testing

lib.sh#L1228

[shellcheck] reported by reviewdog 🐶 Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2059

Raw Output: ./lib.sh:1228:16:info:Don't use variables in the printf format string. Use printf '..%s..' "$foo". SC2059

[szaimen]

Is this still a thing?

[enoch85]

Yes I think so. Just didn't have the time.

[enoch85]

It's the spinner loading function:

spinner_loading() {
    pid=$!
    spin='-\|/'
    i=0
    while kill -0 $pid 2>/dev/null
    do
        i=$(( (i+1) %4 ))
>>>>>>>>        printf "\r[${spin:$i:1}] " # Add text here, something like "Please be patient..." maybe?
        sleep .1
    done
}