search

nextcloud / web-installer

💊 The web installer for Nextcloud
https://download.nextcloud.com/server/installer/setup-nextcloud.php
39 stars 24 forks source link

Show Nextcloud version #5

Closed phsc84 closed 8 years ago

phsc84 commented 8 years ago

Fix for #4.

Plus little adjustements of the welcome text. But I can revert these adjustements, if you don't like it.

jancborchardt commented 8 years ago

Not sure if we want external HTTP requests, O thought everything should be self-contained @MorrisJobke?

MorrisJobke commented 8 years ago

1 additional HTTP request necessary

Yes. It would be nice to have it as self contained as possible. No need to remove the inline image. Because then other problems could occur and this only saves for exact 1 request (usually you don't install nextcloud 10x a day ;)).

MorrisJobke commented 8 years ago

@phsc Could I ask you to remove the change of the image. In general it is easier to have separate pull requests for different changes.

The other change looks good

phsc84 commented 8 years ago

Thank you for your feedback. I will adjust my pull request later this week. And I have to figure out, how I can create multiple pull requests for the same repository...

MorrisJobke commented 8 years ago

And I have to figure out, how I can create multiple pull requests for the same repository...

You can create git branches and each branch could then be the base of a pull request.