search

nextcloud / welcome

Welcome widget in Nextcloud's dashboard
GNU Affero General Public License v3.0
17 stars 11 forks source link

Markdown links should have primary color #14

Open burnoutberni opened 3 years ago

burnoutberni commented 3 years ago

Hi, just installed your app – generally happy with it, but I didn't understand at first, why all of the links in the Markdown files have a different color than in the Markdown editor.

Turns out you use var(--color-text-lighter) while nextcloud/text uses var(--color-primary-element). Any particular reason why?

This is the location of the relevant CSS line: https://github.com/eneiluj/welcome/blob/fac2ca03a6512e1145c13dd3344213321d825135/src/views/Dashboard.vue#L146

Dubidubiduu commented 3 years ago

It is actually hard to read with that low contrast

julien-nc commented 3 years ago

Well there is almost no place in Nextcloud where the link color follows the main theming color.

What do you think about using --color-text-light?

burnoutberni commented 3 years ago

@eneiluj Well, nextcloud/text (and therefore also the Readme preview), links use --color-primary-element – that's why I'd use the same.