search

nextcloud / welcome

Welcome widget in Nextcloud's dashboard
GNU Affero General Public License v3.0
17 stars 11 forks source link

Markdown not being rendered properly #17

Closed RussellNS closed 3 years ago

RussellNS commented 3 years ago

First off, love the widget! It's simple, and does exactly (almost) what I was hoping for.

However, I am running into an issue where the markdown that I'm creating inside Nextcloud is not being displayed the same on the widget. It seems that it renders some/most markdown correctly, but seems to struggle with formatting (bullet indention, sub-bullet indention, bold, extra blank lines, etc.).

I think the best way to show you what I'm getting is with screenshots.

This is a markdown file being edited (and saved) in Nextcloud.

        Welcome Issue 02

This is what's being displayed in the Welcome widget on the dashboard.

        Welcome Issue 01

I've already read on another issue that you're fairly busy on other things currently. I respect that. Any help or direction would be appreciated.

Thank you for any attention you can give to this.

julien-nc commented 3 years ago

Hi, thanks for the bug report.

Thankfully those issues are just style related (meaning the markdown parser works fine). It's now fixed and available in latest nightly build (v1.0.0-1-nightly).

welc_editor welc

You can download the nightly manually from the appstore or you can also simply get it with an occ command:

occ app:update --allow-unstable welcome

When you want to get back to normal releases, just disable and remove the app from app settings and reinstall it. You won't loose any data.

If you try it and confirm it's working fine, I'll make a release.

RussellNS commented 3 years ago

I just tried it. Confirming that it works like a champ! Thank you!

Putting this out here for others: I assume due to some other reason (API, translation, architectual, whatever), the Welcome app doesn't show blank lines. I was able to get around that by manually typing \
in my md file to achieve the same affect.

All in all, very happy, and again, thank you!

julien-nc commented 3 years ago

Thanks for your feedback and your enthusiasm!

the Welcome app doesn't show blank lines

It might be a limitation of the markdown parser library. I'll have a look. You could open a new issue for that to make sure we don't forget about this problem.

RussellNS commented 3 years ago

I'll do that, and include the workaround.