search

nextcloud / welcome

Welcome widget in Nextcloud's dashboard
GNU Affero General Public License v3.0
17 stars 11 forks source link

Use mbstring-extensions as applicable #33

Open joho1968 opened 1 year ago

joho1968 commented 1 year ago

I've just been browsing the code a bit to see if I can contribute, but one thing that I noticed is the use of some non-mbstring string functions.

Since Nextcloud requires the mbstring functions to be present in PHP, I think it'd be a good idea if the welcome app made use of them where applicable.

https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html

(see "Prerequisites for manual installation")

Just my two cents.

kyteinsky commented 1 year ago

The code with non-mbstring functions has been overwritten and since the new functions only handle URIs, I doubt there is any need for mbstrings here. (https://github.com/nextcloud/welcome/commit/b9683f588cd48b30605c620d8808a3de57c60cb6#diff-04ace24b494c1cf87cb15970508f767e982403f9001ea2f5faa80e9f4247f55fR140)