search

nextcloud / welcome

Welcome widget in Nextcloud's dashboard
GNU Affero General Public License v3.0
17 stars 11 forks source link

Added multilingual support (#32) #34

Open joho1968 opened 1 year ago

joho1968 commented 1 year ago

Multilingual support (#32)

The widget supports different languages by appending _lang to the specified filename. So if the original filename is mywelcome.md, the widget will look for mywelcome_sv.md for a user with Swedish set as their language. If that file is not present, the configured filename will be used.

(If the user has no specific language setting, the default language of the Nextcloud instance will be used.)

joho1968 commented 1 year ago

(not sure what happened with my gpg keys, but ... )

joho1968 commented 1 year ago

Any chance of this being merged sometime soon?

kyteinsky commented 1 year ago

Hi! Sorry, it took a bit long to get back to you.

There are two more things you would need to do here:

  1. Rebase this branch with the main branch
  2. Indent the code according to the existing style (tabs) and make it homogenous throughout the file

Thank you for your work!

yennor commented 11 months ago

would love to get that merged :-)

kyteinsky commented 11 months ago

@yennor Me too! Unfortunately, we are a bit stretched out in terms of workforce so it would not be possible to work on it directly. If you can address the above issues in a separate PR, I would be more than happy to review it!

joho1968 commented 11 months ago

There are two more things you would need to do here:

  1. Rebase this branch with the main branch
  2. Indent the code according to the existing style (tabs) and make it homogenous throughout the file

Thank you for your work!

I did update my fork just now, what else do I need to do to rebase it?

I'm sorry, but all my development environments use space characters instead of TABs. Feel free to copy/paste my changes and style them to your liking. The amount of added/changed code really isn't a big deal.

kyteinsky commented 11 months ago

Hey @joho1968
You need to rebase your branch multilang upon the main branch of the nextcloud repo.
If you're using an IDE, it should auto detect the indentation (or have a feature for it). They can also be manually overridden to use tabs.