search

nextcloud / whiteboard

Create & collaborate on an infinite canvas!
https://apps.nextcloud.com/apps/whiteboard
GNU Affero General Public License v3.0
44 stars 3 forks source link

Feature/5 load from file content and save it back #18

Closed JuliaKirschenheuter closed 4 months ago

JuliaKirschenheuter commented 4 months ago

For https://github.com/nextcloud-gmbh/whiteboard/issues/5

grnd-alt commented 4 months ago

I though @hweihwang has already done this in https://github.com/nextcloud-gmbh/whiteboard/pull/16

juliushaertl commented 4 months ago

Haven't tested but just from reading the code I think the file data is only read once starting collaboration (but I might be wrong there).

grnd-alt commented 4 months ago

Haven't tested but just from reading the code I think the file data is only read once starting collaboration (but I might be wrong there).

It's currently loaded once starting Collab and written when a client disconnects both handled by the node server. Idk If this PR adds something I'm forgetting about to it.

juliushaertl commented 4 months ago

We should show the file content directly on open (that was what the pr was aiming for), however ideally we'd of course start collaboration automatically the this would be obsolete

grnd-alt commented 4 months ago

We should show the file content directly on open (that was what the pr was aiming for), however ideally we'd of course start collaboration automatically the this would be obsolete

Collaboration starts automatically without any user interaction as soon as the file is opened and the server is running, the file content is also already loaded instantly

juliushaertl commented 4 months ago

All right, sorry then I had a misunderstanding. We might still want to reconsider this approach then for things like viewing a version where there is no collaboration needed, but we can pause work on that for now.

github-actions[bot] commented 2 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)