JWT authentication & Clean up the board

nextcloud / whiteboard

GNU Affero General Public License v3.0

2 stars 0 forks source link

JWT authentication & Clean up the board #23

Closed hweihwang closed 3 weeks ago

hweihwang commented 1 month ago

[x] See actual Nextcloud user on the board (ongoing)
[x] Expose read only permission through token

juliushaertl commented 1 month ago

Very nice, could you check the Ci failures? Then we can merge 👍

juliushaertl commented 1 month ago

PHPUnit tests seem caused because we have not tests and no test config yet.

juliushaertl commented 3 weeks ago

Thanks @hweihwang

I left two more comments as we need to keep supporting PHP 8.0 for now. Can you also squash the commits either logically or into one final one so we have a clean history?

I noticed when attempting to rebase the PR (I didn't have much time) that there were quite some merge commits that make future rebasing harder. In the future it might be better to only use rebasing to catch up with changes from the base branch.