search

nextcloud / windows-universal

📱 Nextcloud Windows Mobile app
https://www.microsoft.com/store/apps/9nblggh532xq
Mozilla Public License 2.0
59 stars 34 forks source link

Settings: Light/dark/system theme #119

Closed DecaTec closed 7 years ago

DecaTec commented 7 years ago

Let the user choose the app's theme in the settings: Light/dark/system

SunboX commented 7 years ago

This is also related to issue comment https://github.com/nextcloud/windows-universal/issues/18#issuecomment-262774583

DecaTec commented 7 years ago

https://github.com/nextcloud/windows-universal/pull/148

Theme can now be switched, but the app needs to be restarted for the settings to take effect. This settings is saved in the roaming settings of the app.

It's a little more complex to switch themes during runtime. http://stackoverflow.com/questions/34554871/changing-theme-in-windows-10-uwp-app-programmatically

I don't know if it's worth the effort. What do you think?

SunboX commented 7 years ago

I've changed it, because setting it in the App's constructor crashed the share pane view. Now the theming of the message boxes and the kayboard won't change. But I think this is a minor issue. I will try one more thing, don't know if it works.

Also, the app must not be restarted now.

SunboX commented 7 years ago

I found a better way to dynamicall ychange the theme: https://liftcodeplay.com/2015/08/24/themeresource-dark-and-light-themes-in-windows-10/

I will implement this later.