Open thoughtpolice opened 3 days ago
Ahh that's definitely confusing. I'm definitely tempted to tokenize something like not
separately, but I'm worried people are going to be led down an incorrect path, and start thinking of all the boolean operators as prefix operators. A better error message is definitely valuable here.
And yes, --skip
now works :)
Description of the issue
Description: When running the Jujutsu test suite, I'm seeing a flaky test I would like to skip. I tried using the following command after skimming the filterset documentation:
However, this fails with a rather confusing error, because the
not
operator is (I am assuming completely based on no reading of the code) parsed as a functionnot()
which doesn't exist.Simply adding a space
not (...)
in the predicate does what I expect and succeeds.Expected outcome
I expect the test suite to run, and skip the singular test named
test_shallow_commits_lack_parents
Actual result
Nextest version
Additional context
I assume this is some kind of grammar nit, though I'm no expert in parsing, but ideally there should be:
Also, I note that nextest
0.9.80
added (back) support for--skip
, presumably in terms of a filterset-under-the-hood. That would have let me work around this, but this still remains.