search

nextflow-io / nextflow-s3fs

An S3 File System Provider for Java 7 (project archived)
Apache License 2.0
1 stars 10 forks source link

Add path style access option for non-aws S3 storage service provider #18

Closed glmanhtu closed 5 years ago

glmanhtu commented 5 years ago

@pditommaso Could you please have look as this? For now, the nextflow-s3fs only supported domain-based S3 storage. There is no way to make it work with non-aws S3 storage providers that using path style access. This pull request adds an option to make it work with those providers.

According to S3 for java library

Amazon S3 supports virtual-hosted-style and path-style access in all Regions. The path-style syntax, however, requires that you use the region-specific endpoint when attempting to access a bucket.

aws {
      client {
        s3PathStyleAccess = 'true'        
      }
    }
pditommaso commented 5 years ago

I've merged this manually adding the check both for s3_path_style_access and s_3_path_style_access (since the latter is ugly and depends by an issue on nf size).