search

nextflow-io / nextflow

A DSL for data-driven computational pipelines
http://nextflow.io
Apache License 2.0
2.69k stars 621 forks source link

Tower request field `tasks.cloudZone` exceeds expected size nf-tower-plugin #4305

Open Shahbaz-mahmood123 opened 1 year ago

Shahbaz-mahmood123 commented 1 year ago

Bug report

When running a GCP batch compute in Tower for some regions, a warning is returned : WARN: Tower request field tasks.cloudZone exceeds expected size | offending value: northamerica-northeast1, size: 23 (max: 15)`

Looks like we need to increase the limit here:

https://github.com/nextflow-io/nextflow/blob/89ede15c71e79858560f93df71064b74d2da2cf4/plugins/nf-tower/src/resources/tower-schema.properties#L68

List of GCP regions: https://cloud.google.com/about/locations

Looking at the above list, increasing the value to 23 should be sufficient.

I have attached the Nextflow log for a basic hello world.

Environment

bentsherman commented 1 year ago

These limits are derived from the Tower database schema: https://github.com/seqeralabs/nf-tower-cloud/blob/master/tower-migrate/src/main/resources/db-schema/mysql/m01__tower.sql#L15

Looks like cloud_zone has since been extended to 25, so we might as well do the same. In fact we should probably review the whole list to make sure it is in line with the database.