Closed marcodelapierre closed 2 months ago
Name | Link |
---|---|
Latest commit | 941f894cd51bf72d8b35f8f08e863257876e504a |
Latest deploy log | https://app.netlify.com/sites/nextflow-docs-staging/deploys/6634e32d2951f20008eabaa7 |
@pditommaso first round at tackling https://github.com/nextflow-io/nextflow/issues/4851
Do not review entirely yet.
The main caveat, as discussed with Ben inside the issue above, is that at the moment I am gathering information on Wave and Fusion from session.config
, rather than WaveConfig
and FusionConfig
. The main issue I see with this approach (you may see others) is that I am not capturing the Fusion version if it is not explicitly requested by the user.
Thoughts? Thank you
Almost there, one last clarification, see above my reply to one outstanding review comment
Ok, ready for review.
Other than the question on NXF_DISABLE_WAVE_SERVICE
, see comment above in threaded change request, I have addressed the other feedback, in particular the one on refactoring the implementation for the Fusion metadata.
Testing using this snippet
println "Wave enabled : ${workflow.wave.enabled}"
println "Fusion enabled: ${workflow.fusion.enabled}"
println "Fusion version: ${workflow.fusion.version}"
» ./launch.sh run test.nf
N E X T F L O W ~ version 24.03.0-edge
Launching `test.nf` [nauseous_kare] DSL2 - revision: 7e81b68063
Wave enabled : false
Fusion enabled: false
Fusion version: null
» ./launch.sh run test.nf -with-wave
N E X T F L O W ~ version 24.03.0-edge
Launching `test.nf` [kickass_brattain] DSL2 - revision: 7e81b68063
Wave enabled : true
Fusion enabled: false
Fusion version: null
» ./launch.sh run test.nf -with-wave -with-fusion
N E X T F L O W ~ version 24.03.0-edge
Launching `test.nf` [festering_pasteur] DSL2 - revision: 7e81b68063
Wave enabled : true
Fusion enabled: true
Fusion version: null
» NXF_DISABLE_WAVE_SERVICE=true ./launch.sh run test.nf -with-wave -with-fusion
N E X T F L O W ~ version 24.03.0-edge
Launching `test.nf` [gloomy_kalam] DSL2 - revision: 7e81b68063
Wave enabled : false
Fusion enabled: true
Fusion version: null
Think the problem is here
it should be
this.version = this.enabled ? retrieveFusionVersion(this.containerConfigUrl ?: DEFAULT_FUSION_AMD64_URL) : null
But at this point does not make much sense to have version
as attribute and just keep this logic into version()
method
Ok, think we are there. Let's wait the tests
Done!
This PR closes https://github.com/nextflow-io/nextflow/issues/4851 by adding the following metadata information:
Checklist: