nextflow-io / nextflow

A DSL for data-driven computational pipelines
http://nextflow.io
Apache License 2.0
2.61k stars 605 forks source link

Add account config option for grid executors #4975

Closed pditommaso closed 1 month ago

pditommaso commented 1 month ago

This PR adds the ability to define a Slurm account in the nextflow config. For example:

executor {
  account = 'some-project-xyz'
}

Solve https://github.com/nextflow-io/nextflow/issues/4921

Updated to use executor instead of slurm on 7th May

netlify[bot] commented 1 month ago

Deploy Preview for nextflow-docs-staging canceled.

Name Link
Latest commit 08101ec4ea2b115799a2fd44a6890a061a3a5b64
Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/663b3739cd44440008f37a68
bentsherman commented 1 month ago

In this case I recommend also moving executor.perCpuMemAllocation to slurm.perCpuMemAllocation.

marcodelapierre commented 1 month ago

I would suggest exposing this option as a generic executor one, executor.account, rather than creating the new slurm config scope.
Indeed, other executors implement it, e.g. PBS has -P <account/project>.

muffato commented 1 month ago

Hi. I was going to suggest the same thing as @marcodelapierre . LSF has the -G user_group: https://www.ibm.com/docs/en/spectrum-lsf/10.1.0?topic=o-g-1

pditommaso commented 1 month ago

Fair enough

pditommaso commented 1 month ago

@bentsherman @marcodelapierre please have a look and let's merge it

pditommaso commented 1 month ago

Thanks both. I've reverted 9486d68 because it's better to keep explicit from the name is coming from