Open pditommaso opened 1 month ago
Name | Link |
---|---|
Latest commit | a46d4a166d8e0485e89dcaed76ec4e0522fb16de |
Latest deploy log | https://app.netlify.com/sites/nextflow-docs-staging/deploys/667051543a4e0900082c777a |
Deploy Preview | https://deploy-preview-5000--nextflow-docs-staging.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
( a lot of extra commits due to fixing commit sign-offs - sorry! )
@pditommaso ready for review
Maybe we can still improve on messages/behaviour when image is not built, but otherwise the key implementation changes are there.
Still one failing unit test on CI should resolve docker container with wave container
in WaveContainerResolverTest
, call to resolveImage
at line 76.
The responsible bit of code is in WaveContainerResolver
, new lines 98-108.
Looking into it.
@pditommaso @ewels following the meeting today, I have implemented the workaround for the URI in the case of Seqera Containers: https://github.com/nextflow-io/nextflow/blob/wave-sif-http/plugins/nf-wave/src/main/io/seqera/wave/plugin/WaveClient.groovy#L392-L400
Ready for review (with one last unit test to fix)
OK, last outstanding unit test fixed:
@pditommaso ready for review
Do we need an integration test for running with Wave plugin and using Http over Oras?
It may be useful. Some wave tests are here
Let's put in hold, not sure anymore it makes sense to implement this
This PR draft the mapping of ORAS images names to HTTP ones.