nextflow-io / nextflow

A DSL for data-driven computational pipelines
http://nextflow.io
Apache License 2.0
2.61k stars 606 forks source link

Fix the default for async finalizer #5013

Closed pditommaso closed 1 month ago

pditommaso commented 1 month ago

The PR fixes the setting for the NXF_ENABLE_ASYNC_FINALIZER env variable.

The expression 'some string' as boolean is always true unless the string is null or empty.

Therefore the setting is always enabled unless NXF_ENABLE_ASYNC_FINALIZER is set to an empty string.

netlify[bot] commented 1 month ago

Deploy Preview for nextflow-docs-staging canceled.

Name Link
Latest commit f1f67675582b9d8a8277603f7ecba898892a0dd2
Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/664ce36e15f595000837a8f7
pditommaso commented 1 month ago

Wonder if it should be set to true by default at this point

bentsherman commented 1 month ago

Might be better to make it true by default and allow people to disable it if it breaks something for them. We'll get much better testing feedback that way

pditommaso commented 1 month ago

ok