search

nextflow-io / nextflow

A DSL for data-driven computational pipelines
http://nextflow.io
Apache License 2.0
2.61k stars 605 forks source link

Do not require tentantId when using Azure system-assigned managed identity #5065

Closed adamrtalbot closed 2 weeks ago

adamrtalbot commented 2 weeks ago

Azure system-assigned managed identity no longer needs the tenant ID after we updated the Java SDK, but the checks prevented it being allowed. This PR removes the check for system + tenant ID so system assigned identities can be used.

I've tested this to work on an Azure VM with a managed identity.

netlify[bot] commented 2 weeks ago

Deploy Preview for nextflow-docs-staging canceled.

Name Link
Latest commit c579c18dd80b8dbfbd82c73c8affa40dffbdca06
Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/666c1a2526692a00088ca882
pditommaso commented 2 weeks ago

Azure system-assigned managed identity no longer needs the tenant ID

Is there any benefit to using the tenant ID? or should it be removed completely?

adamrtalbot commented 2 weeks ago

Is there any benefit to using the tenant ID? or should it be removed completely?

done

pditommaso commented 2 weeks ago

Merged manually a639a17d