nextflow-io / nextflow

A DSL for data-driven computational pipelines
http://nextflow.io
Apache License 2.0
2.61k stars 605 forks source link

4446 ignore then fail strategy v3 #5071

Closed pditommaso closed 1 week ago

pditommaso commented 1 week ago

This PR implements the fail on ignore by using by setting the option nextflow.enable.failOnIgnore in the nextflow config file.

netlify[bot] commented 1 week ago

Deploy Preview for nextflow-docs-staging ready!

Name Link
Latest commit 65e3eb2da4da35f15cafd1310ec6e47b4dcbe22c
Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66701cca7fc5a700082a8492
Deploy Preview https://deploy-preview-5071--nextflow-docs-staging.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bentsherman commented 1 week ago

I would suggest exposing it as nextflow.failOnIgnore so as to not confuse it with feature flags. Long term I don't think we should allow feature flags in the config because they are inherent to the pipeline code.

bentsherman commented 1 week ago

In other words:

pditommaso commented 1 week ago

That was the first option, but then I realised it's not a feature flag but more a workflow (error handling) behaviour, and as such reported in the workflow metadata

pditommaso commented 1 week ago

Let's go