Big refactor - Githubissues

nextflow-io / nf-nomad

Hashicorp Nomad executor plugin for Nextflow

https://nextflow-io.github.io/nf-nomad/

Apache License 2.0

2 stars 3 forks source link

Big refactor #12

Closed jagedn closed 7 months ago

jagedn commented 7 months ago

This is a refactor of the current project due we're mixing API lib + custom http

It removes lot of comments and unnecessary (by the moment) code

use java library
remove non used code and config

jagedn commented 7 months ago

I would like to include more tests in order to cover specific situations

by the moment I've included an unique test to run a "full pipeline" using a mockWebServer

tomiles commented 7 months ago

@jagedn very nice refactor 👍 looking much more readable now. Made just one remark on the storage/volume stuff above, but we can handle that with a separate PR once we can test on a more production like nomad cluster.